feat(cli): add --connect-timeout
#1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/retry-connect
branch
5 times, most recently
from
74a8316 to
cb6d698
Compare
abonander
force-pushed
the
ab/retry-connect
branch
from
cb6d698 to
2488046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a default 10 second connection timeout to all subcommands.
This addresses sporadic "connection refused" errors when using using
sqlx-cliin automated jobs that start concurrently with a fresh database instance, such as using a Postgres image as a service in Gitlab CI.Normally, I'd expect Gitlab to wait for the database container to be ready before proceeding with the build, and their documentation clearly states that this is already being done.
However, it appears that this is not the case for the Kubernetes executor which we're using in a self-managed Kubernetes cluster to speed up CI since builds with Gitlab's shared runners are glacially slow. Thanks to that misleading (or possibly outdated) bit of documentation, I wasted several hours today trying to figure this out.
Given that the above issue has been open for almost a year, I figured it was just easier to address it on our end.