-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose connect_options
for initialized pools and database
on the PgConnectOptions
#1897
Conversation
32176f4
to
1599574
Compare
@abonander Sorry for the quite sloppy first state of the MR, I should have properly tested it in a fully integrated scenario from the very beginning. |
@Nukesor might want to update the PR name and commit title to reflect the new actual changes. |
database
on the PgConnectOptions
database
on the PgConnectOptions
connect_options
for initialized pools and database
on the PgConnectOptions
I don't think this implementation fixes #1853 as they specifically wanted |
1599574
to
e87ee3d
Compare
True. @Thomasdezeeuww should then easily be able to implement theire desired getters in a follow-up PR. I didn't want to expose the getter without adding specific getters, but I guess it makes sense :) Thanks @abonander for the review 👍 |
@abonander For the record, even if it doesn't fix the original issue it meant to address, it's still very helpful for a case I have right now and would therefore appreciate to see it merged. :) @Nukesor you should remove the issue from the OP so it doesn't auto close upon merging. |
I changed it from |
This is a PoC PR which is related to #1853
The idea is to expose PoolOptions and ConnectionOptions after the pool has been created.
This would allow easy database deletion and modification without having to save the options used during creation for the whole duration of the program.