Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dirs to 5.0.0 #2432

Closed
wants to merge 1 commit into from
Closed

Conversation

marcusirgens
Copy link
Contributor

As far as I can tell, dirs is used only in sqlx-postgres/src/options/pgpass.rs

    #[cfg(not(target_os = "windows"))]
    let default_file = dirs::home_dir().map(|path| path.join(".pgpass"));
    #[cfg(target_os = "windows")]
    let default_file = dirs::data_dir().map(|path| path.join("postgres").join("pgpass.conf"));

The breaking changes between these versions are, according to the authors:

  • Update dirs-sys dependency to 0.4.0.
  • Add config_local_dir for non-roaming configuration on Windows. On non-Windows platforms the behavior is identical to config dir.

home_dir() is Some($HOME) for all non-Windows targets in both 4.0.0 and 5.0.0.
data_dir() is Some({FOLDERID_RoamingAppData}) for Windows in both 4.0.0 and 5.0.0

I cannot find any references to dirs in sqlx-mysql. Is it possible it is no longer used in that package?

@abonander
Copy link
Collaborator

@marcusirgens when restructuring the crates I just copy-pasted the dependencies from one to another as I didn't want to sift through them individually and a lot of them were used by every driver. If the dirs crate isn't used by sqlx-mysql you can go ahead and remove it if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants