Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.3→v0.7.0 SQLite bump without any other changes #2455

Closed
wants to merge 5 commits into from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 13, 2023

This PR addresses libsqlite3-sys security issue, by simply updating it in the v0.6.3, and due to the breaking change, bumping the version to v0.7.0, per #1163 (comment)

Note that this SHOULD NOT be merged to main. Maintainers, please create a new branch named v0.6 based on the tag v0.6.3. This way I can retarget this PR to it, it can be merged and deployed, while the main branch will be bumped to 0.8+

@nyurik nyurik mentioned this pull request Apr 13, 2023
30 tasks
@abonander
Copy link
Collaborator

#2094 (comment)

@abonander abonander closed this Apr 13, 2023
@abonander
Copy link
Collaborator

We've gotten yelled at before for upgrading libsqlite3-sys because there can be only one version of it in the dependency graph, making it a breaking change for anyone using it directly or rusqlite.

@nyurik
Copy link
Contributor Author

nyurik commented Apr 13, 2023

@abonander please take a look at #1163 (comment) -- that's the whole idea of this PR -- sqlx can release v0.7.0 (a breaking change), while all the current code in the main branch will be treated as v0.8.0+

@nyurik
Copy link
Contributor Author

nyurik commented Apr 13, 2023

P.S. In other words, a release version is cheap -- we do not need to release the current main as v0.7 -- it just as well can be release as v0.8 or even v1.0 -- as long as we indicate that the sqlite bump is not compatible with v0.6.3 (by making it v0.7+), we can move forward

@abonander
Copy link
Collaborator

We already have alphas out for the next release and people have started to migrate to them. I plan to set aside some time to prepare the full release in the next week or so.

Unless another one has popped up that I don't know about (this is the one we're talking about, right?), I disagree with the severity of the CVE as it is relatively straightforward to audit your codebase for, would require manual user intervention to fix either way, and passing untrustworthy, unvalidated, unlimited-size strings to a C function via SQL seems like a bad idea to begin with.

@nyurik nyurik deleted the sqlite-bump-v0.6.3 branch May 24, 2023 16:51
@nyurik nyurik restored the sqlite-bump-v0.6.3 branch May 24, 2023 16:51
@nyurik nyurik deleted the sqlite-bump-v0.6.3 branch September 5, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants