-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump syn to 2.0 #2482
chore: bump syn to 2.0 #2482
Conversation
I'm not sure whether this one is needed or should be taken into account ATM, but keeping |
The removal of type ascription is a significant breaking change, at least for our own dogfooding usage. I'd like to at least try to provide deprecation warnings for it before we drop it entirely. |
Fair enough. Should I leave this PR in draft? I can try and come up with a following PR with a deprecation notice. |
Yeah if you like. I think it would be as simple as adding a hidden, public function to |
b7d986b
to
a8db9d7
Compare
Any progress? Trying eliminate syn 1 from our dependencies. |
@Sytten we're targeting the next major release, but I'm unaware of any plans or dates. |
@saiintbrisson do you have time to come back to this? I'm finally committing to getting 0.8.0 out |
a8db9d7
to
11eefa1
Compare
11eefa1
to
5049646
Compare
@abonander should be good to go. On a completely different note, I've been thinking for a while now about adding a new feature flag |
I'm not necessarily against that, I suppose. |
@abonander Ill create the mentioned PR when this one gets merged, lmk if you need anything. |
This PR bumps the
syn
crate to the new major 2.0 version. Following what some of the dependenciesare using as well (
serde 1.0.159
,futures 0.3.27
,tokio 1.26.0
).It seems like now is a good time to bump before the 0.7 release. Some of the breakages include:
AttributeArgs
no longer exists, we mustPunctured
directly;NestedMeta
no longer exists.LifetimeDef
is nowLifetimeParam
;The
parse_nested_meta
replaces whatever would be done usingAttributeArgs
.