Prevent passwords from being logged #2839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As passwords were treated as Strings, and Debug was derived, any debug logging would print the full password in the diagnostic logs of the applicaiton running this library. By wrapping the password in Secret and implementing most traits, we can (almost) seamlessly prevent passwords from being displayed in those contexts.
| @@ -183,6 +183,44 @@ impl LogSettings { | |||
| } | |||
| } | |||
|
|
|||
| /// `Secret` is a wrapper around a String which ensures it is not going | |||
There was a problem hiding this comment.
Suggested change
| /// `Secret` is a wrapper around a String which ensures it is not going | |
| /// `Secret` is a wrapper around a String which ensures it is going |
|
@feikesteenbergen do you intend to finish this? |
|
Closing due to inactivity. Feel free to reopen if you plan to finish this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As passwords were treated as Strings, and Debug was derived, any debug logging would print the full password in the diagnostic logs of the applicaiton running this library.
By wrapping the password in Secret and implementing most traits, we can (almost) seamlessly prevent passwords from being displayed in those contexts.