Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Implements proposal (1) + (2) from #3051
acquire
torelease
. This reduces the number of query-time reconnections due to max lifetimemin_connections
connections and they just sit idle. Then query time, we discover they are over max_lifetime and have to reconnect. With this change, the connections are actually replaced everymax_lifetime
and can be used when needed.I'm open to other ideas but this seems to me like a strictly better default than the current one. One question is whether we should be replacing connection below
min_connections
due to being idle - this PR does that but I can see the argument for doing that only with max_lifetime