expose relation_id and relation_attribution_no on PgColumn #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Sep 7, 2024
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
|
Thanks for the suggestions! |
abonander
approved these changes
Sep 7, 2024
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
…nchbadge#3492) * expose relation_id and relation_attribution_no on PgColumn * Update sqlx-postgres/src/message/row_description.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/column.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/message/row_description.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/column.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/message/row_description.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * fix --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
jrasanen
pushed a commit
to jrasanen/sqlx
that referenced
this pull request
Oct 14, 2024
…nchbadge#3492) * expose relation_id and relation_attribution_no on PgColumn * Update sqlx-postgres/src/message/row_description.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/column.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/message/row_description.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/column.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * Update sqlx-postgres/src/message/row_description.rs Co-authored-by: Austin Bonander <austin.bonander@gmail.com> * fix --------- Co-authored-by: Austin Bonander <austin.bonander@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a tool that does introspection on queries that requires reading relation_id and attribute number from postgres queries. Today, sqlx keeps those fields private.
This PR exposes those fields, along with a small data type correction to relation_id - it's an Oid, which is a u32, not a i32.