Remove unused dependencies from sqlx-core, sqlx-cli and sqlx-postgres #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, a lot of these were left over from moving the database drivers out into their own crates. It would be really nice if Cargo or rustc linted about unused external crates. |
There is this tool: https://github.com/bnjbvr/cargo-machete that can integrated to the github workflow. We have it setup for our internal packages and it does do a pretty decent job I have to say and quite simple in logic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are quite some unused dependencies in sqlx-core and sqlx-cli. And one crate from sqlx-postgres.
Cargo builds with all features after removing these dependencies.