- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.5k
          feat: support json in Any driver
          #3998
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            JosiahParry
  wants to merge
  21
  commits into
  launchbadge:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
JosiahParry:feat/json-any
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            21 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      36c9728
              
                implement decode and encode for json
              
              
                JosiahParry cfc7f8b
              
                add any json test
              
              
                JosiahParry fc1de8f
              
                address lints
              
              
                JosiahParry 4ebb40c
              
                change any tests to suppor postgres better
              
              
                JosiahParry 1b0e32d
              
                use ? instead of
              
              
                JosiahParry 1b7e223
              
                new commit to retry ci since it failed via rewwest
              
              
                JosiahParry 7d2161a
              
                add argument mapping for sqlx and postgres
              
              
                JosiahParry 18bbab8
              
                add mysql mapping
              
              
                JosiahParry 35364e4
              
                clippy
              
              
                JosiahParry 977b381
              
                us  instead of ?
              
              
                JosiahParry a97b22a
              
                Merge branch 'launchbadge:main' into feat/json-any
              
              
                JosiahParry 63e4340
              
                revert Type<DB> impl for Box<JsonRawValue>
              
              
                JosiahParry 4fd03ec
              
                use feature flags for query format
              
              
                JosiahParry 6c90493
              
                revert Cargo.toml
              
              
                JosiahParry 402ce89
              
                copy directly from main
              
              
                JosiahParry 34bf530
              
                add newline to cargo.toml
              
              
                JosiahParry c08603e
              
                Merge branch 'feat/json-any' into dev-merge
              
              
                JosiahParry 62db1b2
              
                Merge pull request #1 from JosiahParry/dev-merge
              
              
                JosiahParry 4334d3f
              
                remove lifetyime requirements ffrom AnyArguments and related for AnyJson
              
              
                JosiahParry c775fbc
              
                add json as default feature sqlx-cli
              
              
                JosiahParry ecebbde
              
                clippy
              
              
                JosiahParry File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -50,6 +50,7 @@ features = [ | |
| "runtime-tokio", | ||
| "migrate", | ||
| "any", | ||
| "json" | ||
| ] | ||
|  | ||
| [features] | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| use crate::any::{Any, AnyArgumentBuffer, AnyTypeInfo, AnyTypeInfoKind, AnyValueKind, AnyValueRef}; | ||
| use crate::decode::Decode; | ||
| use crate::encode::{Encode, IsNull}; | ||
| use crate::error::BoxDynError; | ||
| use crate::types::{Json, Type}; | ||
| use serde::{Deserialize, Serialize}; | ||
|  | ||
| impl<T> Type<Any> for Json<T> { | ||
| fn type_info() -> AnyTypeInfo { | ||
| AnyTypeInfo { | ||
| kind: AnyTypeInfoKind::Json, | ||
| } | ||
| } | ||
|  | ||
| fn compatible(ty: &AnyTypeInfo) -> bool { | ||
| matches!( | ||
| ty.kind, | ||
| AnyTypeInfoKind::Json | AnyTypeInfoKind::Text | AnyTypeInfoKind::Blob | ||
| ) | ||
| } | ||
| } | ||
|  | ||
| impl<T> Encode<'_, Any> for Json<T> | ||
| where | ||
| T: Serialize, | ||
| { | ||
| fn encode_by_ref(&self, buf: &mut AnyArgumentBuffer) -> Result<IsNull, BoxDynError> { | ||
| let json_string = self.encode_to_string()?; | ||
| let raw_value = serde_json::value::RawValue::from_string(json_string)?; | ||
| buf.0.push(AnyValueKind::Json(raw_value)); | ||
| Ok(IsNull::No) | ||
| } | ||
| } | ||
|  | ||
| impl<T> Decode<'_, Any> for Json<T> | ||
| where | ||
| T: for<'de> Deserialize<'de>, | ||
| { | ||
| fn decode(value: AnyValueRef<'_>) -> Result<Self, BoxDynError> { | ||
| match value.kind { | ||
| #[cfg(feature = "json")] | ||
| AnyValueKind::Json(raw) => Json::decode_from_string(raw.get()), | ||
| AnyValueKind::Text(text) => Json::decode_from_string(text), | ||
| AnyValueKind::Blob(blob) => Json::decode_from_bytes(blob), | ||
| other => other.unexpected(), | ||
| } | ||
| } | ||
| } | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abonander this is the one change that I am somewhat concerned about being "breaking." This change is required because the sqlx-cli is pulling in the json feature even though
default-features = falseis specified. This causes some weirdness in the compilation only for sqlx-cli and I cannot figure out how to resolve it.You can see this with
cargo tree -p sqlx-cli --format "{p} {f}" -i sqlx-core. Thejsonandanyfeatures are being pulled in but the json feature isn't added into the dependency tree inCargo.toml. This is the only way I could resolve the sqlx-cli issues.