fix(compose): use OS-assigned ports for all conatiners #4007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't follow the steps in `tests/README.md` because two containers failed to bind to the same port, already used by a local running database.
|
The check failed because of a random timeout from |
abonander
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
I was going to reject this change as unnecessary, since you can override the port in the docker compose run command like we do in CI here: https://github.com/launchbadge/sqlx/blob/c5037f1fca18018fb9605a8e2b49faaddb9fb269/.github/workflows/sqlx.yml#L231C1-L231C144
However, I see that this is actually fixing a consistency issue in this file, as we already don't assign a host port for any of the other services. So it's pretty benign.
abonander
changed the title
JosiahParry
pushed a commit
to JosiahParry/sqlx
that referenced
this pull request
Sep 24, 2025
I couldn't follow the steps in `tests/README.md` because two containers failed to bind to the same port, already used by a local running database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't follow the steps in
tests/README.mdbecause two containers failed to bind to the same port, already used by a locally running database.Does your PR solve an issue?
No. I didn't create one just for such a simple change.
Is this a breaking change?
No, it doesn't even touch the Rust code.