Rename sqlx(rename) attribute to sqlx(type_name) #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
rename-type-name
branch
from
120214a
to
90b99ff
Compare
abonander
requested changes
Dec 30, 2020
abonander
requested changes
Jan 4, 2021
There was a problem hiding this comment.
I'm not a big fan of how the deprecation error turned out, at the very least it needs to be clear it's talking about attributes. Also, would you mind adjusting the documentation here
sqlx/sqlx-core/src/types/mod.rs
Line 111 in 02eea35
| 10 | compile_error!("trybuild test needs to fail for stderr checking"); | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| warning: use of deprecated function `sqlx::_rename`: sqlx(rename) is now called sqlx(type_name) |
There was a problem hiding this comment.
Eh, this isn't great. In our experience, people get confused easily if the error messages aren't direct enough. I would make sure to be clear we're talking about #[sqlx(rename = "...")] and #[sqlx(type_name = "...")] if we can, otherwise it'd just be better to emit an error.
It's nice that it's pointing at the correct span at least.
jplatte
force-pushed
the
rename-type-name
branch
from
02eea35
to
05712e1
Compare
|
Updated the docs and deprecation note, is this better? |
abonander
reviewed
Jan 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested on Discord.