Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android:allowBackup=true is back in Release 3.0.0 #138

Closed
oorlov opened this issue Aug 31, 2021 · 4 comments
Closed

android:allowBackup=true is back in Release 3.0.0 #138

oorlov opened this issue Aug 31, 2021 · 4 comments

Comments

@oorlov
Copy link

oorlov commented Aug 31, 2021

Describe the bug
Release 3.0.0 added android:allowBackup=true back to the AndroidManifest.xml
Because of this app developers have to use tools:replace="android:allowBackup" as a workaround.
In general libraries are not supposed to declare this specific flag (unless there is some special use for it? Maybe?)

To reproduce

  • Create an Android app with Android Studio default layout
  • Add allowBackup=false into application within AndroidManifest.xml
  • Add implementation 'com.launchdarkly:launchdarkly-android-client-sdk:3.1.0' to the app/build.gradle
  • Get a build error:
Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:29:9-36
	is also present at [com.launchdarkly:launchdarkly-android-client-sdk:3.1.0] AndroidManifest.xml:13:9-35 value=(true).
	Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:21:5-103:19 to override.

Expected behavior
Adding implementation 'com.launchdarkly:launchdarkly-android-client-sdk:3.1.0' shouldn't cause build error due to allowBackup conflict

Language version, developer tools
AndroidStudio 4.1.3

OS/platform
OS X, but should be any
@oorlov
Copy link
Author

oorlov commented Aug 31, 2021

Caused by this I believe:
https://github.com/launchdarkly/android-client-sdk/pull/126/files#diff-4ea1d5d45e25fbd99af946e3fed3b51b84b61585974e6056d92e25710d108376R8

@gwhelanLD
Copy link
Contributor

Hi @oorlov,

Thanks for the issue report. We'll release a patch to address this issue. For the moment, you can follow the instructions in the error message to include `tools:replace="android:allowBackup" as a workaround.

Thanks,
@gwhelanLD

@gwhelanLD gwhelanLD mentioned this issue Sep 3, 2021
Merged
gwhelanLD added a commit that referenced this issue Sep 3, 2021
@gwhelanLD
Release 3.1.1 (#139)
d4e5095 
## [3.1.1] - 2021-09-03
### Fixed
- Removed the `android:allowBackup` tag from the SDK's `AndroidManifest.xml` file to avoid requiring applications to explicitly replace the tag if given a different value. ([#138](#138))
- Changed the SDK's network detection check to consider network transport over a VPN as a connected state. This fixes an issue where the SDK would prevent network requests on a VPN due to considering the network to be unavailable. (Thanks, [lguipeng](#137)!)
@gwhelanLD
Copy link
Contributor

Hi @oorlov,

This should be resolved in the 3.1.1 release of the SDK.

Thanks for the report!
@gwhelanLD

Merged
@oorlov
Copy link
Author

oorlov commented Sep 6, 2021

@gwhelanLD Thank you! It works well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oorlov @gwhelanLD