Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare 4.2.2 release #220

Merged
merged 512 commits into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
512 commits
Select commit Hold shift + click to select a range
24f08b1
Merge pull request #246 from launchdarkly/eb/sc-160828/disable-contra…
eli-darkly Aug 23, 2022
95eaeef
use okhttp-eventsource 1.11.3
eli-darkly Aug 23, 2022
551ab96
Merge pull request #245 from launchdarkly/eb/sc-164297/secure-random
eli-darkly Aug 23, 2022
5caabf4
ensure timed-out clients get closed in contract tests
eli-darkly Aug 23, 2022
1b2e4c1
clean up instances map on close (#247)
eli-darkly Aug 23, 2022
f93743b
rm unnecessary LDClientControl
eli-darkly Aug 23, 2022
e33318a
Merge branch 'main' into eb/sc-165480/contract-tests-close-client
eli-darkly Aug 23, 2022
da45fe6
Merge pull request #248 from launchdarkly/eb/sc-165480/contract-tests…
eli-darkly Aug 23, 2022
a7f0fd8
merge from public after release
Aug 23, 2022
01e1732
Merge branch 'main' into 4.0
eli-darkly Aug 23, 2022
70cd057
use com.launchdarkly.logging with Timber adapter (#235)
eli-darkly Aug 23, 2022
c9537de
Merge branch 'main' into 4.0
eli-darkly Aug 23, 2022
288cef6
merge from public after release
Aug 23, 2022
6b5d371
use fully-qualified context key in flag store (doesn't include migrat…
eli-darkly Aug 23, 2022
a17eacd
Merge branch 'main' into lc/sc-135900/bump-gradle
eli-darkly Aug 23, 2022
37c21d8
suppress contract tests for inline users in events
eli-darkly Aug 23, 2022
4ed1d01
rm unused plugin
eli-darkly Aug 23, 2022
e9e6f8a
update more user references to contexts
eli-darkly Aug 24, 2022
27017e5
use LDContext in API and evaluations; disable events for now
eli-darkly Aug 25, 2022
cc3ef38
update some more references to "users"
eli-darkly Aug 25, 2022
fd01e10
add contract test support for context type
eli-darkly Aug 25, 2022
2493c92
fix test
eli-darkly Aug 25, 2022
1f84eb3
adopt new event processor
eli-darkly Aug 25, 2022
23a0a4e
rm redundant class
eli-darkly Aug 25, 2022
4732a22
Merge pull request #220 from launchdarkly/lc/sc-135900/bump-gradle
louis-launchdarkly Aug 25, 2022
f351d27
Merge branch 'main' into 4.0
eli-darkly Aug 26, 2022
f9c04f5
Merge branch '4.0' into eb/sc-165512/contexts-1-store-key
eli-darkly Aug 26, 2022
9d973ff
update snapshot version
eli-darkly Aug 26, 2022
403a93d
Merge branch '4.0' into eb/sc-165512/contexts-1-store-key
eli-darkly Aug 26, 2022
25bdf3d
Merge branch 'eb/sc-165512/contexts-1-store-key' into eb/sc-165945/co…
eli-darkly Aug 26, 2022
7452c48
Merge branch 'eb/sc-165512/contexts-1-store-key' into eb/sc-165945/co…
eli-darkly Aug 26, 2022
f8cfdc5
Merge branch 'eb/sc-165945/contexts-2-use-context' into eb/sc-165440/…
eli-darkly Aug 26, 2022
ccc5af5
fix tiny inconsistency in build.gradle
eli-darkly Aug 26, 2022
d633772
set request paths for event sender
eli-darkly Aug 26, 2022
54519d4
fix private attributes configuration
eli-darkly Aug 26, 2022
262df4e
make test expectation correspond to the endpoint we're using now
eli-darkly Aug 26, 2022
a78e8d5
fix HTTP cache configuration
eli-darkly Aug 26, 2022
b6138b7
fix test
eli-darkly Aug 26, 2022
847db06
remove debug output
eli-darkly Aug 26, 2022
f0d93c7
misc fixes
eli-darkly Aug 26, 2022
b56f48b
add config option for generating anonymous keys
eli-darkly Aug 30, 2022
9767943
Merge pull request #250 from launchdarkly/eb/sc-165512/contexts-1-sto…
eli-darkly Sep 7, 2022
f854d83
test should be testing trackData
eli-darkly Sep 8, 2022
523dbe9
fix anonymous key logic
eli-darkly Sep 8, 2022
4f0e09a
add storage abstraction and use it in ContextDecorator
eli-darkly Sep 8, 2022
9435d3e
Merge branch 'eb/sc-165945/contexts-2-use-context' into eb/sc-165440/…
eli-darkly Sep 8, 2022
b2c3448
Merge branch 'eb/sc-165440/contexts-3-events' into eb/sc-165536/gener…
eli-darkly Sep 8, 2022
82be818
Merge branch 'eb/sc-165536/generate-keys' into eb/sc-166194/storage-1…
eli-darkly Sep 8, 2022
1f69ab3
rm inapplicable comment
eli-darkly Sep 8, 2022
1ab0d3b
update evaluation endpoint paths
eli-darkly Sep 8, 2022
6895c21
Merge branch 'eb/sc-168424/new-endpoints' into eb/sc-165440/contexts-…
eli-darkly Sep 8, 2022
1f5b28b
Merge branch 'eb/sc-165440/contexts-3-events' into eb/sc-165536/gener…
eli-darkly Sep 8, 2022
00970ec
Merge branch 'eb/sc-165536/generate-keys' into eb/sc-166194/storage-1…
eli-darkly Sep 8, 2022
1a7bf55
refactor more components to use storage abstraction
eli-darkly Sep 9, 2022
5d0b5ce
misc fixes
eli-darkly Sep 9, 2022
9639dbe
Merge pull request #251 from launchdarkly/eb/sc-165945/contexts-2-use…
eli-darkly Sep 9, 2022
766834e
Merge pull request #257 from launchdarkly/eb/sc-168424/new-endpoints
eli-darkly Sep 9, 2022
becca28
Merge pull request #254 from launchdarkly/eb/sc-165440/contexts-3-events
eli-darkly Sep 9, 2022
6f02b15
Merge pull request #255 from launchdarkly/eb/sc-165536/generate-keys
eli-darkly Sep 9, 2022
594461c
debugging
eli-darkly Sep 9, 2022
072bee8
debugging
eli-darkly Sep 9, 2022
b096f8d
debugging
eli-darkly Sep 9, 2022
be042d0
substitute simple in-memory persistence in contract tests
eli-darkly Sep 9, 2022
fce6754
rm debugging, move test fixture
eli-darkly Sep 9, 2022
f79c3db
Merge pull request #256 from launchdarkly/eb/sc-166194/storage-1-intf
eli-darkly Sep 9, 2022
ea1d93f
comment
eli-darkly Sep 9, 2022
0f850a5
create PersistentDataStoreWrapper component to encapsulate storage sc…
eli-darkly Sep 14, 2022
59df625
misc cleanup, comments
eli-darkly Sep 14, 2022
4faa28d
ensure test log tag name isn't too long
eli-darkly Sep 14, 2022
8c8ef98
rm unused
eli-darkly Sep 14, 2022
4ae9294
rm unused
eli-darkly Sep 14, 2022
fb3c9df
spacing
eli-darkly Sep 14, 2022
2a12a98
Merge branch 'eb/sc-166194/storage-2-components' into eb/sc-166194/st…
eli-darkly Sep 15, 2022
e6cfcb9
Merge pull request #258 from launchdarkly/eb/sc-166194/storage-2-comp…
eli-darkly Sep 15, 2022
979ebe1
major refactoring of context/flag manager components and Connectivity…
eli-darkly Sep 16, 2022
17f7127
rm duplicate test
eli-darkly Sep 17, 2022
6bc1381
revert unnecessary change
eli-darkly Sep 19, 2022
45ab654
rm redundant helper
eli-darkly Sep 19, 2022
e24f2e5
clearer handling of exceptions in Gson deserialization
eli-darkly Sep 19, 2022
421374f
Merge branch 'eb/sc-166194/storage-3-wrapper' into eb/sc-166194/stora…
eli-darkly Sep 19, 2022
09e74c5
improve test logging: add full test name to log line, force enable debug
eli-darkly Sep 19, 2022
6ac07d0
misc fixes
eli-darkly Sep 19, 2022
86306f2
more cleanup of JSON parsing logic
eli-darkly Sep 19, 2022
f37f623
create module for shared test code
eli-darkly Sep 20, 2022
8171ae9
tolerate missing keys in flag data
eli-darkly Sep 20, 2022
80a8300
Merge branch 'eb/sc-166194/storage-4-manager' into eb/sc-166194/stora…
eli-darkly Sep 20, 2022
7c59bd2
rm redundant class
eli-darkly Sep 20, 2022
db6e210
rm unused
eli-darkly Sep 20, 2022
4fee9f0
create PlatformState abstraction
eli-darkly Sep 22, 2022
725e4c6
misc cleanup, factor various properties out into ClientState
eli-darkly Sep 23, 2022
a664b40
rm tests that can't possibly work in any supported API version
eli-darkly Sep 23, 2022
9213580
fix tests, move network listener to ConnectivityManager
eli-darkly Sep 23, 2022
31a5345
comments
eli-darkly Sep 23, 2022
ae86352
fix error logging
eli-darkly Sep 23, 2022
bfcf52d
discard pre-v4 SDK data, migrate anon user key if possible
eli-darkly Sep 27, 2022
24aedab
clean up leftover polling alarms
eli-darkly Sep 27, 2022
1e9854f
simplify by moving triggerPoll logic inside ConnectivityManager
eli-darkly Sep 27, 2022
d3b5343
Merge branch 'eb/sc-166194/platform-state' into eb/sc-165971/migration
eli-darkly Sep 27, 2022
51e6534
use regular worker threads for polling instead of AlarmManager
eli-darkly Sep 27, 2022
1c109ea
simplify further by moving Debounce usage into ConnectivityManager
eli-darkly Sep 27, 2022
0819b50
Merge branch 'eb/sc-166194/platform-state' into eb/sc-165971/migration
eli-darkly Sep 27, 2022
c49f658
Merge branch 'eb/sc-165971/migration' into eb/sc-170849/no-alarm-manager
eli-darkly Sep 27, 2022
6f441bb
Merge pull request #265 from launchdarkly/eb/sc-169505/cleanup-alarm
eli-darkly Sep 28, 2022
c1f7664
Merge pull request #259 from launchdarkly/eb/sc-166194/storage-3-wrapper
eli-darkly Sep 28, 2022
dfb6be5
merge from public after release
Sep 28, 2022
19c2de8
config streamlining: ServiceEndpoints
eli-darkly Sep 28, 2022
7e7c1e4
move LDConfigTest to unit tests and fix warning message
eli-darkly Sep 28, 2022
770cd4b
update okhttp-eventsource version + streaming timeout fix
eli-darkly Sep 29, 2022
1b8e76c
update contract tests
eli-darkly Sep 29, 2022
fbab78c
rm obsolete manifest entry
eli-darkly Sep 29, 2022
46f37f3
Merge branch 'eb/sc-170849/no-alarm-manager' into eb/sc-162830/update…
eli-darkly Sep 29, 2022
adf9d81
update ProGuard rules file
eli-darkly Sep 29, 2022
4c9278e
javadoc fix
eli-darkly Sep 29, 2022
b773a43
fix endpoint config in contract tests
eli-darkly Sep 29, 2022
31ef56e
add temporary test suppressions
eli-darkly Sep 29, 2022
ff7cf59
create ClientContext object as a standard way to pass configuration t…
eli-darkly Sep 30, 2022
b2b7cf0
fix javadoc
eli-darkly Sep 30, 2022
b029582
Merge pull request #260 from launchdarkly/eb/sc-166194/storage-4-manager
eli-darkly Oct 11, 2022
a82b9a0
Merge pull request #261 from launchdarkly/eb/sc-166194/storage-5-shar…
eli-darkly Oct 13, 2022
440f02b
Merge pull request #263 from launchdarkly/eb/sc-166194/platform-state
eli-darkly Oct 25, 2022
8cd49ec
don't use connection pool/keep-alive for polling requests
eli-darkly Oct 27, 2022
5a754bb
Merge pull request #271 from launchdarkly/eb/sc-173149/keep-alive
eli-darkly Oct 27, 2022
50fd34e
Merge pull request #264 from launchdarkly/eb/sc-165971/migration
eli-darkly Oct 27, 2022
2948fb5
Merge pull request #266 from launchdarkly/eb/sc-170849/no-alarm-manager
eli-darkly Oct 27, 2022
9abf2fd
Merge pull request #267 from launchdarkly/eb/sc-162830/update-eventso…
eli-darkly Oct 27, 2022
ac3e047
merge from public after release
Oct 27, 2022
749daef
Merge pull request #268 from launchdarkly/eb/sc-170848/config-1-endpo…
eli-darkly Oct 28, 2022
8bcff0d
Merge pull request #269 from launchdarkly/eb/sc-166196/proguard
eli-darkly Oct 28, 2022
91b481f
Merge pull request #270 from launchdarkly/eb/sc-170848/config-2-clien…
eli-darkly Oct 28, 2022
1f9710d
add sub-configuration builder for events
eli-darkly Nov 9, 2022
110ce35
diagnosticRecordingInterval should also be part of the new builder
eli-darkly Nov 9, 2022
0134de4
misc fixes
eli-darkly Nov 9, 2022
7326eea
remove deprecated usages & unused imports
eli-darkly Nov 9, 2022
ef80ba6
misc fixes
eli-darkly Nov 9, 2022
d978fcc
revert unnecessary change
eli-darkly Nov 9, 2022
cab2b24
doc comments
eli-darkly Nov 9, 2022
4d58b3e
add configuration builders for polling/streaming
eli-darkly Nov 9, 2022
f77bbc7
fix polling mode initialization
eli-darkly Nov 9, 2022
f8c57b1
fix diagnostic event properties
eli-darkly Nov 9, 2022
4d5c806
fix logic for diagnostic recording interval
eli-darkly Nov 9, 2022
5f3a475
Merge branch 'eb/sc-176169/events-config-builder' into eb/sc-176169/d…
eli-darkly Nov 9, 2022
1d10a18
fix tests
eli-darkly Nov 9, 2022
29c37a1
fix defaulting logic
eli-darkly Nov 9, 2022
10c7809
(4.0) add sub-configuration for events
eli-darkly Nov 10, 2022
cf3304f
fix test
eli-darkly Nov 10, 2022
5e077d5
fix merge
eli-darkly Nov 10, 2022
e1d8700
(4.0) add sub-configuration for data source
eli-darkly Nov 10, 2022
3472c64
fix tests
eli-darkly Nov 10, 2022
9f6e4a8
add configuration builder for HTTP
eli-darkly Nov 10, 2022
3d2829e
improve tests
eli-darkly Nov 10, 2022
6b13c4f
Merge branch 'eb/sc-176169/events-config-builder' into eb/sc-176169/d…
eli-darkly Nov 10, 2022
c7faa1e
test cleanup
eli-darkly Nov 10, 2022
dd766d8
Merge branch 'eb/sc-176169/data-source-config' into eb/sc-176169/http…
eli-darkly Nov 10, 2022
49b500b
Merge branch 'eb/sc-176169/events-config-builder' into eb/sc-170848/e…
eli-darkly Nov 10, 2022
213b5a6
Merge branch 'eb/sc-170848/events-config-v4' into eb/sc-170848/data-s…
eli-darkly Nov 10, 2022
fbc2baf
Merge branch 'eb/sc-176169/data-source-config' into eb/sc-170848/data…
eli-darkly Nov 10, 2022
6c5be69
fix test
eli-darkly Nov 10, 2022
fedfeca
(4.0) add configuration builder for HTTP
eli-darkly Nov 10, 2022
778bcd6
fix example code
eli-darkly Nov 10, 2022
c412326
add configuration builder for service endpoints
eli-darkly Nov 11, 2022
571a6c4
misc fixes
eli-darkly Nov 11, 2022
24894e4
disable diagnostic events if analytics events are disabled
eli-darkly Nov 11, 2022
b58798a
Merge branch 'eb/sc-176169/events-config-builder' into eb/sc-176169/d…
eli-darkly Nov 11, 2022
8ccf17a
deprecations
eli-darkly Nov 11, 2022
6d869f6
Merge branch 'eb/sc-176169/data-source-config' into eb/sc-176169/http…
eli-darkly Nov 11, 2022
5bbc013
Merge branch 'eb/sc-176169/http-config' into eb/sc-176169/service-end…
eli-darkly Nov 11, 2022
94edc02
revise streaming/polling components to use a pluggable data source ab…
eli-darkly Nov 15, 2022
da2b70c
don't keep summary event counters in SharedPreferences
eli-darkly Nov 15, 2022
b937dc2
don't create a summary event if there's no data
eli-darkly Nov 15, 2022
9b5debb
misc cleanup + comments
eli-darkly Nov 16, 2022
7a45404
rm duplicated lines
eli-darkly Nov 17, 2022
c2e0729
use regular in-memory storage for summary events (customer-reported p…
eli-darkly Nov 17, 2022
09d4328
fix doc comment
eli-darkly Nov 17, 2022
d53534d
merge from public after release
Nov 17, 2022
891b95a
Merge branch 'eb/sc-176628/in-memory-summary' into eb/sc-176169/event…
eli-darkly Nov 17, 2022
dd2ef74
Merge branch 'eb/sc-176169/events-config-builder' into eb/sc-176169/d…
eli-darkly Nov 17, 2022
073d6c3
Merge branch 'eb/sc-176169/data-source-config' into eb/sc-176169/http…
eli-darkly Nov 17, 2022
87b5b0e
Merge branch 'eb/sc-176169/http-config' into eb/sc-176169/service-end…
eli-darkly Nov 17, 2022
54db35a
Merge pull request #272 from launchdarkly/eb/sc-176169/events-config-…
eli-darkly Nov 17, 2022
ab0981a
Merge branch 'main' into 4.0
eli-darkly Nov 17, 2022
1415c96
Merge branch '4.0' into eb/sc-170848/events-config-v4
eli-darkly Nov 17, 2022
eec40a3
Merge branch 'new-config-v3' into eb/sc-170848/events-config-v4
eli-darkly Nov 17, 2022
57b45b6
Merge branch 'eb/sc-170848/events-config-v4' into eb/sc-170848/data-s…
eli-darkly Nov 17, 2022
ad9155a
Merge branch 'eb/sc-176169/data-source-config' into eb/sc-170848/data…
eli-darkly Nov 17, 2022
7ce4bcf
Merge pull request #273 from launchdarkly/eb/sc-176169/data-source-co…
eli-darkly Nov 17, 2022
badceff
Merge branch 'eb/sc-170848/data-source-config-v4' into eb/sc-170848/h…
eli-darkly Nov 18, 2022
785ee52
Merge branch 'eb/sc-170848/http-config-v4' into eb/sc-170848/data-sou…
eli-darkly Nov 18, 2022
b0c0607
add overloads for using LDUser instead of LDContext
eli-darkly Nov 18, 2022
a936ea1
update Proguard rules file
eli-darkly Nov 21, 2022
ff8f2ab
Merge pull request #274 from launchdarkly/eb/sc-170848/events-config-v4
eli-darkly Nov 21, 2022
763389e
Merge pull request #275 from launchdarkly/eb/sc-170848/data-source-co…
eli-darkly Nov 22, 2022
429878d
fix @since
eli-darkly Nov 22, 2022
1a06ed0
Merge branch 'eb/sc-176169/http-config' into eb/sc-170848/http-config-v4
eli-darkly Nov 22, 2022
fb0883d
Merge pull request #276 from launchdarkly/eb/sc-176169/http-config
eli-darkly Nov 22, 2022
491c82a
Merge pull request #278 from launchdarkly/eb/sc-176169/service-endpoints
eli-darkly Nov 22, 2022
abc9c35
Merge pull request #281 from launchdarkly/eb/sc-177360/re-add-user
eli-darkly Nov 23, 2022
c725caa
Merge pull request #277 from launchdarkly/eb/sc-170848/http-config-v4
eli-darkly Nov 23, 2022
e55b85e
Merge branch '4.0' into eb/sc-170848/data-source-component
eli-darkly Nov 23, 2022
914ebbb
fix test
eli-darkly Nov 23, 2022
6dac31e
Merge pull request #280 from launchdarkly/eb/sc-170848/data-source-co…
eli-darkly Dec 2, 2022
e1dece8
merge from public after release
Dec 2, 2022
02368f3
(4.0) add test data source (#282)
eli-darkly Dec 6, 2022
80b94ce
use latest package versions
eli-darkly Dec 6, 2022
290b04f
Merge branch '4.0' of github.com:launchdarkly/android-client-sdk-priv…
eli-darkly Dec 6, 2022
45c3e06
Merge branch 'main' into 4.0
eli-darkly Dec 6, 2022
21a7d66
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
eli-darkly Dec 7, 2022
c93a8d0
if SDK starts in the background, do an initial poll
eli-darkly Dec 19, 2022
ae2a9f9
Merge pull request #284 from launchdarkly/eb/sc-180975/first-bg-poll
eli-darkly Dec 19, 2022
43cc527
merge from public after release
Dec 19, 2022
8b51827
add "use streaming even in background" option (4.x)
eli-darkly Dec 20, 2022
6a93669
Merge pull request #285 from launchdarkly/eb/sc-180978/streaming-in-bg
eli-darkly Dec 21, 2022
dc14802
do an initial poll if SDK starts in the background (3.x) (#286)
eli-darkly Dec 21, 2022
7ff8032
Merge branch '3.x' of github.com:launchdarkly/android-client-sdk into…
eli-darkly Dec 21, 2022
63747e2
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
eli-darkly Dec 21, 2022
14d9d73
merge from public after release
Dec 21, 2022
0cfbece
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
eli-darkly Dec 22, 2022
ecdc5f3
add streamEvenInBackground option (3.x) (#287)
eli-darkly Dec 23, 2022
c952cb6
merge from public after release
Dec 23, 2022
81ac594
merge from public after release
Dec 23, 2022
4985a30
Merge branch '3.x' of github.com:launchdarkly/android-client-sdk into…
eli-darkly Dec 23, 2022
10be9dd
merge from public after release
Dec 23, 2022
ced39cf
Merge branch '3.x' of github.com:launchdarkly/android-client-sdk-priv…
eli-darkly Dec 23, 2022
ab5ed5c
Merge branch '3.x'
eli-darkly Dec 23, 2022
b176b21
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
eli-darkly Dec 23, 2022
82851dc
re-fix previous fix for connection keep-alive
eli-darkly Jan 7, 2023
e442577
Merge pull request #288 from launchdarkly/eb/sc-173149/no-keepalive-2
eli-darkly Jan 7, 2023
a66aa0a
prepare 3.5.1 release (#205)
LaunchDarklyReleaseBot Jan 7, 2023
7914ab9
update obsolete credential paths
eli-darkly Jan 7, 2023
51d876b
Releasing version 3.5.1
Jan 7, 2023
2358429
merge from public after release
Jan 7, 2023
c6d4bd3
Merge branch '3.x'
eli-darkly Jan 7, 2023
b4f1f30
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
eli-darkly Jan 7, 2023
c9b168e
add ApplicationInfo a.k.a. tags (3.x) (#289)
eli-darkly Jan 11, 2023
952fadc
prepare 3.6.0 release (#207)
LaunchDarklyReleaseBot Jan 11, 2023
b766252
Releasing version 3.6.0
Jan 11, 2023
1c59672
merge from public after release
Jan 11, 2023
7692534
Merge branch '3.x'
eli-darkly Jan 11, 2023
45ce580
add ApplicationInfo a.k.a. tags (4.x) (#290)
eli-darkly Jan 12, 2023
aa2297d
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
eli-darkly Jan 12, 2023
eca48f7
Added missing callback
tanderson-ld Mar 13, 2023
4f92a7f
Adding missing call to register/unregister in unit test found in review.
tanderson-ld Mar 14, 2023
bff3f89
Merge pull request #291 from launchdarkly/ta/sc-191967/registerAllFla…
tanderson-ld Mar 14, 2023
38ed2d9
merge from public after release
Mar 15, 2023
ca3c045
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
louis-launchdarkly Mar 23, 2023
5bc1d8c
Merge branch 'main' of github.com:launchdarkly/android-client-sdk
louis-launchdarkly Apr 11, 2023
366afce
Adding null checks around members accessed in LDClient.close(). Also…
tanderson-ld May 16, 2023
b0fa1d7
Fixing incorrect unit test related to double close of LDClient.
tanderson-ld May 16, 2023
514e80b
fix: close twice causing NPE (#292)
tanderson-ld May 17, 2023
11b1a81
Updating java-sdk-common to 2.0.1 to include bugfix.
tanderson-ld May 17, 2023
dd56447
Updating java-sdk-common to 2.0.1 to include bugfix. (#293)
tanderson-ld May 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion launchdarkly-android-client-sdk/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ ext.versions = [
"jacksonCore": "2.10.5",
"jacksonDatabind": "2.10.5.1",
"junit": "4.13",
"launchdarklyJavaSdkCommon": "2.0.0",
"launchdarklyJavaSdkCommon": "2.0.1",
"launchdarklyJavaSdkInternal": "1.0.0",
"launchdarklyLogging": "1.1.1",
"okhttp": "4.9.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,11 @@ public void testInitMissingContext() throws Exception {
assertTrue("No future task to run", ldClientFuture.isDone());
}

// the second ldClient.close() should throw a npe
@Test
public void testDoubleClose() throws IOException {
LDClient ldClient = LDClient.init(application, makeOfflineConfig(), ldUser, 1);
ldClient.close();
try {
ldClient.close();
fail("expected exception");
} catch (NullPointerException e) {}
ldClient.close();
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,9 @@ public AndroidPlatformState(
this.taskExecutor = taskExecutor;
this.logger = logger;

if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
connectivityReceiver = new ConnectivityReceiver();
IntentFilter filter = new IntentFilter(ConnectivityReceiver.CONNECTIVITY_CHANGE);
application.registerReceiver(connectivityReceiver, filter);
} else {
connectivityReceiver = null;
}
connectivityReceiver = new ConnectivityReceiver();
IntentFilter filter = new IntentFilter(ConnectivityReceiver.CONNECTIVITY_CHANGE);
application.registerReceiver(connectivityReceiver, filter);

// When we are first starting up, we can't use the ActivityLifecycleCallbacks mechanism to
// determine whether we're in the foreground or not, because the last foreground or
Expand Down Expand Up @@ -101,7 +97,7 @@ public boolean isNetworkAvailable() {
try {
android.net.ConnectivityManager cm = (android.net.ConnectivityManager)
application.getSystemService(Context.CONNECTIVITY_SERVICE);
if (Build.VERSION.SDK_INT >= 23) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
Network net = cm.getActiveNetwork();
if (net == null)
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -566,9 +566,14 @@ public void close() throws IOException {
closeInstances();

synchronized (initLock) {
sharedTaskExecutor.close();
if (sharedTaskExecutor != null) {
sharedTaskExecutor.close();
}
sharedTaskExecutor = null;
sharedPlatformState.close();

if (sharedPlatformState != null) {
sharedPlatformState.close();
}
sharedPlatformState = null;
}
}
Expand Down