Skip to content
lint

fix: Handle exception closing stream for unavailable adapter on windows. #1775

Sign in to view logs

fix: Handle exception closing stream for unavailable adapter on windows.

fix: Handle exception closing stream for unavailable adapter on windows. #1775

Triggered via pull request July 24, 2024 19:38
@kinyoklionkinyoklion
synchronize #427
rlamb/sc-251111/stream-close-crash
Status Success
Total duration 1m 34s
Artifacts –

cpp-linter.yml

on: pull_request
cpp-linter
1m 20s
cpp-linter
Fit to window
Zoom out
Zoom in

Annotations

10 warnings and 1 notice
/libs/server-sent-events/src/../include/launchdarkly/sse/client.hpp:47:5 [readability-inconsistent-declaration-parameter-name]: libs/server-sent-events/src/../include/launchdarkly/sse/client.hpp#L47
function 'launchdarkly::sse::Builder::Builder' has a definition with different parameter names
/libs/server-sent-events/src/client.cpp:63:45 [performance-unnecessary-value-param]: libs/server-sent-events/src/client.cpp#L63
the parameter 'executor' is copied for each invocation but only used as a const reference; consider making it a const reference
/libs/server-sent-events/src/client.cpp:67:16 [bugprone-easily-swappable-parameters]: libs/server-sent-events/src/client.cpp#L67
4 adjacent parameters of 'FoxyClient' of similar type ('std::optional<std::chrono::milliseconds>') are easily swapped by mistake
/libs/server-sent-events/src/client.cpp:91:26 [performance-move-const-arg]: libs/server-sent-events/src/client.cpp#L91
passing result of std::move() as a const reference argument; no move will actually happen
/libs/server-sent-events/src/client.cpp:126:23 [bugprone-unchecked-optional-access]: libs/server-sent-events/src/client.cpp#L126
unchecked access to optional value
/libs/server-sent-events/src/client.cpp:157:13 [bugprone-unchecked-optional-access]: libs/server-sent-events/src/client.cpp#L157
unchecked access to optional value
/libs/server-sent-events/src/client.cpp:162:9 [bugprone-unchecked-optional-access]: libs/server-sent-events/src/client.cpp#L162
unchecked access to optional value
/libs/server-sent-events/src/client.cpp:181:9 [bugprone-unchecked-optional-access]: libs/server-sent-events/src/client.cpp#L181
unchecked access to optional value
/libs/server-sent-events/src/client.cpp:182:9 [bugprone-unchecked-optional-access]: libs/server-sent-events/src/client.cpp#L182
unchecked access to optional value
/libs/server-sent-events/src/client.cpp:196:9 [bugprone-unchecked-optional-access]: libs/server-sent-events/src/client.cpp#L196
unchecked access to optional value
Run clang-format on libs/server-sent-events/src/client.cpp: libs/server-sent-events/src/client.cpp#L1
File libs/server-sent-events/src/client.cpp does not conform to Custom style guidelines. (lines 353)