fix: Summarizer::VariationKey operator< was unsound

launchdarkly · Jun 1, 2024 · fbbbe8f · fbbbe8f
1 parent af0333f
commit fbbbe8f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/libs/internal/include/launchdarkly/events/detail/summarizer.hpp b/libs/internal/include/launchdarkly/events/detail/summarizer.hpp
@@ -89,8 +89,11 @@ class Summarizer {
         bool operator<(VariationKey const& k) const {
             if (variation < k.variation) {
                 return true;
+            } else if (variation > k.variation) {
+                return false;
+            } else {
+                return version < k.version;
             }
-            return version < k.version;
         }
     };