fix: Summarizer::VariationKey operator< was unsound #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/sc-246162/unsound-comparison-op
branch
from
fbbbe8f to
2370fae
Compare
cwaldren-ld
force-pushed
the
cw/sc-246162/unsound-comparison-op
branch
from
af894f0 to
34e0ef3
Compare
kinyoklion
approved these changes
Jun 11, 2024
Merged
cwaldren-ld
pushed a commit
that referenced
this pull request
Jun 12, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-cpp-client: 3.6.1</summary> ## [3.6.1](launchdarkly-cpp-client-v3.6.0...launchdarkly-cpp-client-v3.6.1) (2024-06-11) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.8.0 to 0.8.1 </details> <details><summary>launchdarkly-cpp-internal: 0.8.1</summary> ## [0.8.1](launchdarkly-cpp-internal-v0.8.0...launchdarkly-cpp-internal-v0.8.1) (2024-06-11) ### Bug Fixes * Summarizer::VariationKey operator< was unsound ([#412](#412)) ([57f45b2](57f45b2)) </details> <details><summary>launchdarkly-cpp-server: 3.5.1</summary> ## [3.5.1](launchdarkly-cpp-server-v3.5.0...launchdarkly-cpp-server-v3.5.1) (2024-06-11) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-internal bumped from 0.8.0 to 0.8.1 </details> <details><summary>launchdarkly-cpp-server-redis-source: 2.1.9</summary> ## [2.1.9](launchdarkly-cpp-server-redis-source-v2.1.8...launchdarkly-cpp-server-redis-source-v2.1.9) (2024-06-11) ### Dependencies * The following workspace dependencies were updated * dependencies * launchdarkly-cpp-server bumped from 3.5.0 to 3.5.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a soundness bug that was detected by MSVC in debug configuration.
The
Summarizer::VariationKeyhas==and<operators.In the case of
<, the comparison wasn't properly handling the case wherethis->variationwas greater than the parameter. In that case, it would fall back to comparingthis->versionwhich is incorrect (should only happen if the variations are equal.)This could have affected the JSON serialization of the summary counters, mainly the order in which the array was serialized. I'm wondering if it could also caused bugs in actual counts.
std::mapuses the<operator to determine key equality.