Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change notification consistency. #473

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

kinyoklion
Copy link
Member

The store should be updated before events are dispatched to ensure consistent data between event information and variation calls.

The store should be updated before events are dispatched to ensure
consistent data between event information and variation calls.
@kinyoklion kinyoklion force-pushed the rlamb/sdk-1057/fix-change-handler-order branch from ebde89a to dd31298 Compare January 28, 2025 17:50
@kinyoklion kinyoklion marked this pull request as ready for review January 28, 2025 18:18
@kinyoklion kinyoklion requested a review from a team as a code owner January 28, 2025 18:18
@kinyoklion kinyoklion merged commit 45fd755 into main Jan 28, 2025
23 checks passed
@kinyoklion kinyoklion deleted the rlamb/sdk-1057/fix-change-handler-order branch January 28, 2025 18:27
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
kinyoklion pushed a commit that referenced this pull request Jan 28, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>launchdarkly-cpp-client: 3.8.2</summary>

##
[3.8.2](launchdarkly-cpp-client-v3.8.1...launchdarkly-cpp-client-v3.8.2)
(2025-01-28)


### Bug Fixes

* Change notification consistency.
([#473](#473))
([45fd755](45fd755))
* Remove type alias import for JSON system_error that was removed in
boost 1.87.
([c0ef518](c0ef518))
* Remove vendored boost file to compile with boost 1.87.
([c0ef518](c0ef518))
* Update usage of the steady_timer to be compatible with boost 1.87.
([c0ef518](c0ef518))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * launchdarkly-cpp-internal bumped from 0.10.0 to 0.10.1
    * launchdarkly-cpp-sse-client bumped from 0.5.4 to 0.5.5
</details>

<details><summary>launchdarkly-cpp-internal: 0.10.1</summary>

##
[0.10.1](launchdarkly-cpp-internal-v0.10.0...launchdarkly-cpp-internal-v0.10.1)
(2025-01-28)


### Bug Fixes

* Remove type alias import for JSON system_error that was removed in
boost 1.87.
([c0ef518](c0ef518))
* Remove vendored boost file to compile with boost 1.87.
([c0ef518](c0ef518))
* Update usage of the steady_timer to be compatible with boost 1.87.
([c0ef518](c0ef518))
</details>

<details><summary>launchdarkly-cpp-server: 3.8.1</summary>

##
[3.8.1](launchdarkly-cpp-server-v3.8.0...launchdarkly-cpp-server-v3.8.1)
(2025-01-28)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * launchdarkly-cpp-internal bumped from 0.10.0 to 0.10.1
    * launchdarkly-cpp-sse-client bumped from 0.5.4 to 0.5.5
</details>

<details><summary>launchdarkly-cpp-server-redis-source: 2.1.17</summary>

##
[2.1.17](launchdarkly-cpp-server-redis-source-v2.1.16...launchdarkly-cpp-server-redis-source-v2.1.17)
(2025-01-28)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * launchdarkly-cpp-server bumped from 3.8.0 to 3.8.1
</details>

<details><summary>launchdarkly-cpp-sse-client: 0.5.5</summary>

##
[0.5.5](launchdarkly-cpp-sse-client-v0.5.4...launchdarkly-cpp-sse-client-v0.5.5)
(2025-01-28)


### Bug Fixes

* Remove type alias import for JSON system_error that was removed in
boost 1.87.
([c0ef518](c0ef518))
* Remove vendored boost file to compile with boost 1.87.
([c0ef518](c0ef518))
* Update usage of the steady_timer to be compatible with boost 1.87.
([c0ef518](c0ef518))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants