This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
prepare 1.0.0-beta16 release #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow users to have empty string keys
Also return default value instead of null value.
misc cleanup prior to official beta release
clean up unnecessary static references and make tests stable
break out & simplify basic flag evaluation tests, remove fixtures
add tests for event generation
throw exception if user is null; assign unique key if key is null or empty
… works but some errors do appear in the log, further investigation required
…onfig): platform specific unit tests build and pass
…m specific unit tests, removed console.writelines, added background polling to default config, fixed polling processor start when streamin is enabled
# Conflicts: # src/LaunchDarkly.Xamarin/LaunchDarkly.Xamarin.csproj
…Handle platform adapter dispose exception, remove unnecessary android asset, remove platform adapter as a config option
…d.cs, MobilePollingProcessor.shared.cs): removed updatebackgroundasync from backgrounding state, readded android asset to fix build, added polling interval based on foreground or background and streaming disabled, removed PingAndWait
…ment to factory method
Removed Xamarin.Essentials, added platform specific unit tests, added platform conditional compilation, added foreground/background listening for background polling
Add "os" and "device" attributes to user
create package during build + update dependency versions
torchhound
approved these changes
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1.0.0-beta16] - 2019-04-05
Added:
Configuration.BackgroundPollingInterval(default: 60 minutes).Configuration.WithEvaluationReasonsandILdMobileClient.BoolVariationDetail.osanddeviceas part of the user data, indicating the user's platform and OS version. This is the same as what the native Android and iOS SDKs do, except that "iOS" or "Android" is also prepended to theosproperty.Changed:
Fixed:
CancellationTokenSourceobject could be leaked.