This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Xamarin.Essentials, added platform specific unit tests, added platform conditional compilation, added foreground/background listening for background polling
Add "os" and "device" attributes to user
create package during build + update dependency versions
# Conflicts: # src/LaunchDarkly.Xamarin/LaunchDarkly.Xamarin.csproj
use new package naming convention
(1 of 2) clean up platform code, don't throw NotImplementedException
.NET Standard 2.0 implementation of persistent storage
better error handling for persistent storage
Added identical value check to SetOnlineAsync
disable REPORT mode because it doesn't work in Android yet
update WireMock, re-enable HTTP tests for Android
put event processor off/online based on Offline property + network status
generate XML comment files
torchhound
approved these changes
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1.0.0-beta23] - 2019-08-30
Added:
Changed:
Online
property ofLdClient
was not useful because it could reflect either a deliberate change to whether the client is allowed to go online (that is, it would be false if you had setOffline
to true in the configuration), or a change in network availability. It has been removed and replaced withOffline
, which is only used for explicitly forcing the client to be offline. This is a read-only property; to set it, useSetOffline
orSetOfflineAsync
.Identify
method now requires a timeout parameter, and returns false if it times out.LdClient.Initialized
is now a property, not a method.LdClient.Version
is now static, since it describes the entire package rather than a client instance.Configuration
andIConfigurationBuilder
,HttpClientTimeout
is nowConnectionTimeout
.Fixed:
Configuration.EnableBackgroundUpdating
was true.client.Online = true
, or callingawait client.SetOnlineAsync(true)
(the equivalent now would beclient.Offline = false
, etc.), the SDK was returning too soon before it had acquired flags from LaunchDarkly. The known issues in 1.0.0-beta22 have been fixed.Removed:
ConfigurationBuilder.UseReport
. Due to an issue with the Android implementation of HTTP, the HTTP REPORT method is not currently usable in the Xamarin SDK.IConnectionManager
interface. The SDK now always uses a platform-appropriate implementation of this logic.