feat: Redact anonymous attributes within feature events #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #228721: Anonymous attribute redaction for feature events. |
kinyoklion
reviewed
Jan 10, 2024
| @@ -8,7 +8,8 @@ | |||
|
|
|||
| %% API | |||
| -export([ | |||
| format_context_for_event/2 | |||
| format_context_for_event/2, | |||
There was a problem hiding this comment.
Do we have a use-case for the version without anonymous redaction?
There was a problem hiding this comment.
There isn't an explicit use case called out in the internal discussion, but the change does stipulate that we should only redact those attributes for feature events, not every event. Is that what you mean?
There was a problem hiding this comment.
Ok. So we redact all attributes for anonymous contexts only in the feature event, but would keep them in an identify.
kinyoklion
approved these changes
Jan 10, 2024
Base automatically changed from
mk/sc-224795/inline-context-events
to
feat/inline-contexts
January 16, 2024 15:05
keelerm84
force-pushed
the
mk/sc-228721/anonymous-redaction
branch
from
f1fe9ac to
37f2476
Compare
keelerm84
added a commit
that referenced
this pull request
Mar 14, 2024
keelerm84
pushed a commit
that referenced
this pull request
Mar 14, 2024
🤖 I have created a release *beep* *boop* --- ## [3.2.0](v3.1.0...v3.2.0) (2024-03-14) ### Features * Always inline contexts for feature events ([#119](#119)) ([e5c6cc4](e5c6cc4)) * Redact anonymous attributes within feature events ([#120](#120)) ([d334861](d334861)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.