Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jsx to 3.1 #35

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Upgrade jsx to 3.1 #35

merged 1 commit into from
Jun 25, 2021

Conversation

bitwalker
Copy link
Contributor

We're starting to see dependency conflicts due to a requirement in this project on jsx 2.9.0, this PR simply updates to jsx 3.0.0.

@bwoskow-ld
Copy link
Member

Hi @bitwalker ,

Thanks for the suggestion. I see that version 3.1.0 is now available, and so we'd want to update to that instead of just 3.0.0. If you want to update the PR for 3.1.0 that would be great.

We'll run some internal testing to validate that nothing breaks, and will get back to you.

Tracked internally as 111003.

@bitwalker
Copy link
Contributor Author

@bwoskow-ld Sure thing!

@bitwalker
Copy link
Contributor Author

Done, let me know if anything else is needed on my end. Thanks for the quick response!

@bitwalker bitwalker changed the title Upgrade jsx to 3.0 Upgrade jsx to 3.1 Jun 9, 2021
Copy link
Member

@bwoskow-ld bwoskow-ld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@bwoskow-ld bwoskow-ld merged commit 6a586e8 into launchdarkly:master Jun 25, 2021
@bwoskow-ld bwoskow-ld mentioned this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants