feat: Implement otel tracing hook. #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR should be reviewed before other hooks PRs. This PR adds supporting types for hooks, but does not use them from the client. --------- Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Second PR. This connects hooks to the ldclient. It does not add the `Ex` methods to any interface, and it does not add `AddHooks` to any interface. --------- Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
kinyoklion
commented
Mar 28, 2024
…sts. (#131) This is a "chore" because I plan on rebase merging this feature branch and this is not a release-note change.
kinyoklion
commented
Apr 1, 2024
| @@ -20,22 +20,38 @@ COVERAGE_ENFORCER_FLAGS=-package github.com/launchdarkly/go-server-sdk/v7 \ | |||
| -skipcode "// COVERAGE" \ | |||
| -packagestats -filestats -showcode | |||
|
|
|||
| .PHONY: build clean test test-coverage benchmarks benchmark-allocs lint | |||
| ALL_BUILD_TARGETS=sdk ldotel | |||
There was a problem hiding this comment.
Should we add the test service? It does not pass linting right now, because it doesn't seem to have accounted for the nested modules not working with ./....
There was a problem hiding this comment.
I am going with no. We can add it to linting later, but fixing all its lint problems will need a PR as well.
|
This PR should not be merged until after hooks have been released in a go-server-sdk version. |
kinyoklion
commented
Apr 1, 2024
keelerm84
reviewed
Apr 1, 2024
cwaldren-ld
reviewed
Apr 1, 2024
|
Changed my mind and added things here. |
|
I think I have convinced myself to have 2 ci workflows though, and will do that here. Other monorepo tasks would be: |
cwaldren-ld
reviewed
Apr 10, 2024
cwaldren-ld
reviewed
Apr 10, 2024
cwaldren-ld
approved these changes
Apr 10, 2024
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
This was referenced Apr 10, 2024
kinyoklion
added a commit
that referenced
this pull request
Apr 11, 2024
🤖 I have created a release *beep* *boop* --- ## [7.4.0](v7.3.0...v7.4.0) (2024-04-10) This release contains no functional changes. It is a product of structural changes to the repository. ### Features * Implement otel tracing hook. ([#130](#130)) ([f5675c1](f5675c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
kinyoklion
pushed a commit
that referenced
this pull request
Apr 11, 2024
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2024-04-11) ### Features * Implement otel tracing hook. ([#130](#130)) ([f5675c1](f5675c1)) * Update to use go-server-sdk 7.4.0 ([#147](#147)) ([0603a9a](0603a9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the otel hook.
Adds a workspace.
Before using the workspace you need to: