Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get started hyperlink #96

Merged

Conversation

christgf
Copy link
Contributor

@christgf christgf commented Aug 2, 2023

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

The issue was not recorded.

Describe the solution you've provided

The "Getting Started" hyperlink in the README seems to be wrong, and following it lands you in a 404 error page. This PR changes it so that it points to the "Getting Started" section of the Launch Darkly docs site.

Describe alternatives you've considered

No alternatives were considered.

Additional context

Stumbled upon the issue while going through the README.

@louis-launchdarkly
Copy link
Contributor

Hello @christgf, thank you for the contribution. This is a mistake and thank you for fixing it. Let me approve and merge your change.

@louis-launchdarkly louis-launchdarkly merged commit c0846f1 into launchdarkly:v6 Aug 2, 2023
LaunchDarklyReleaseBot added a commit that referenced this pull request Oct 11, 2023
## [6.1.1] - 2023-10-11
### Fixed:
- Event payloads receiving an HTTP 413 status code will no longer
prevent subsequent event payloads from being attempted.
- Readme Get started hyperlink destination. (Thanks,
[christgf](#96)!)

---------

Co-authored-by: Eli Bishop <eli@launchdarkly.com>
Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com>
Co-authored-by: Harpo Roeder <hroeder@launchdarkly.com>
Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com>
Co-authored-by: Sam Stokes <sstokes@launchdarkly.com>
Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com>
Co-authored-by: Casey Waldren <cwaldren@launchdarkly.com>
Co-authored-by: Louis Chan <lchan@launchdarkly.com>
Co-authored-by: LaunchDarklyCI <LaunchDarklyCI@users.noreply.github.com>
Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com>
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com>
Co-authored-by: Ember Stevens <79482775+ember-stevens@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants