Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cortex docs #60

Merged
merged 12 commits into from
Dec 4, 2023
Merged

Conversation

cristinabuenahora
Copy link
Contributor

@cristinabuenahora cristinabuenahora commented Nov 15, 2023

Requirements

Intended availability

Partner integration available to anyone who is both a Cortex & LaunchDarkly customer

Related issues

N/A

Describe the solution you've provided

Integration docs: https://docs.cortex.io/docs/reference/integrations/launchdarkly

Describe alternatives you've considered

N/A

Provide a request preview

> @launchdarkly/integration-framework@1.0.0 preview
> node preview.js cortex

The "cortex" integration does not make any outbound requests from LaunchDarkly.

Additional context

N/A

Copy link
Contributor

@InTheCloudDan InTheCloudDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristinabuenahora just a few minor changes and we can get this merged. The docs are already live.

integrations/cortex/manifest.json Outdated Show resolved Hide resolved
integrations/cortex/manifest.json Outdated Show resolved Hide resolved
integrations/cortex/manifest.json Outdated Show resolved Hide resolved
@bwoskow-ld bwoskow-ld requested a review from a team November 29, 2023 19:33
Co-authored-by: Dan O'Brien <dobrien.nj@gmail.com>
"supportWebsite": "https://support.getcortexapp.com/",
"privacyPolicy": "https://www.cortex.io/legal/privacy-policy"
},
"categories": ["developer-tools", "infrastructure"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@InTheCloudDan Thoughts on adding an "internal-developer-portal" category?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristinabuenahora I'll chat with our Docs team about it. There is additional work we're going to be doing to align our tags in-app with better categorization but I don't want to block this PR on it. If we do add it I'll come back and update!

@InTheCloudDan InTheCloudDan enabled auto-merge (squash) December 4, 2023 18:28
@InTheCloudDan InTheCloudDan merged commit 2858ca3 into launchdarkly:main Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants