Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chronosphere partner integration #61

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

sophia-hanley
Copy link
Contributor

@sophia-hanley sophia-hanley commented Dec 12, 2023

Requirements

Intended availability
partner integration

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided
Creates a new integration for Chronosphere Change Events, the functionality takes in a secretToken and receiver URL and will work for auditLogEvents

Describe alternatives you've considered

If you're modifying an existing integration, provide a clear and concise description of any alternative solutions or features you've considered.

Provide a request preview

Include the output from running npm run preview chronosphere.

URL:    $RECEIVERURL
METHOD: POST
HEADER: Content-Type: application/json
HEADER: X-LD-Signature: $SECRETTOKEN
BODY:	targeting-rule-update.json
{
}

Additional context

This is a bit hard to test, but I'm expecting the empty template to pass through the body as it is when setting up a normal webhook integration

@sophia-hanley sophia-hanley changed the title add chronosphere partner integration [WIP] add chronosphere partner integration Dec 12, 2023
@sophia-hanley sophia-hanley marked this pull request as ready for review December 13, 2023 18:29
@sophia-hanley sophia-hanley changed the title [WIP] add chronosphere partner integration add chronosphere partner integration Dec 13, 2023
{
"effect": "allow",
"resources": ["proj/*:env/production:flag/*"],
"actions": ["*"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sophia-hanley I'll be pulling this manifest locally to test it but wanted to mentioned with this wildcard for actions, you'll end up receiving a number of change events that are probably not what you're interested in. For example things like tags being added/removed from a flag. They'll have no affect on the runtime.

You can see our suggested list here: https://docs.launchdarkly.com/guides/integrations/build-audit-log-event-hook/?q=building#manifestjson-example though you could even drop the segment section from it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, I took a look and added the specific actions we're interested in. @InTheCloudDan did this work when you ended up pulling it locally?

@sophia-hanley
Copy link
Contributor Author

@InTheCloudDan it looks like i don't have permission to merge this PR, is there anything left to do on my end?

@InTheCloudDan
Copy link
Contributor

@sophia-hanley nope, you're all set I'm merging today and will follow up via email with the team.

@InTheCloudDan InTheCloudDan merged commit 8c2aa7f into launchdarkly:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants