Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager warning from the Quick package; need to update Quick #243

Closed
chrismanderson opened this issue Mar 26, 2021 · 6 comments

Comments

@chrismanderson
Copy link

chrismanderson commented Mar 26, 2021

Describe the bug
We're getting a build warning

Showing Recent Messages
found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
/Users/user/Library/Developer/Xcode/DerivedData/MyApp-crxxzeaxkeceisgpqbvrnkkdtjsk/SourcePackages/checkouts/Quick/Sources/Quick/Info.plist

when building our application with the LaunchDarkly SDK added via SPM. It appears that Quick released a bug fix for this issue Quick/Quick#1048 - can we get the LD updated with that bug fix?

To reproduce
Add LD SDK version 5.4.0 to my app - build the app.

Expected behavior
The app builds with no SPM warnings related to the LaunchDarkly SDK.

Logs

Showing Recent Messages
found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
/Users/user/Library/Developer/Xcode/DerivedData/MyApp-crxxzeaxkeceisgpqbvrnkkdtjsk/SourcePackages/checkouts/Quick/Sources/Quick/Info.plist

SDK version
5.4.0

Language version, developer tools
Xcode 12.4, iOS 12-14

Additional context
Ideally, the solution isn't to update Quick but to exclude the testing packages - Nimble, Quick, etc, from the main package. It's somewhat odd to have these packages brought into my application when they aren't being used - it's additional dependencies we need to pull down and build even though we aren't using them, and they are only for the LD tests. Can you add them only to the test target instead of the main package?

@torchhound
Copy link
Contributor

Hi @chrismanderson thanks for reporting this.

Filed internally as 104328

@chrismanderson
Copy link
Author

Thanks @torchhound. Happen to have a rough expectation of when this will be resolved?

@yammada
Copy link

yammada commented Apr 7, 2021

I also ran into this issue and I opened #242 to update Quick, but excluding them if possible would be great as well.

@bobergj
Copy link

bobergj commented May 31, 2021

+1 on removing these dependencies from the main package. They just increase package download time on fresh builds on our CI. Also, we are using newer versions of Quick and Nimble in our own test target. Having multiple versions of these packages on the Xcode workspace adds noise.

@mchan-genetec
Copy link

mchan-genetec commented Jun 3, 2021

The inclusion of Quick also introduces a transitive dependency on the kramdown 2.3.1 package which has a critical security issue and one high security issue.

@gwhelanLD gwhelanLD reopened this Jun 17, 2021
gwhelanLD added a commit that referenced this issue Jun 18, 2021
## [5.4.2] - 2021-06-17
### Fixed
- Update `Package.swift` to use SwiftPM tools version 5.2. This prevents test dependencies from being included transitively. (Thanks, [@escakot](#234)!)
- Update `Quick` test dependency to 3.1.2 to avoid build warnings and adopt security fixes. ([#243](#243))
- Use `AnyObject` over `class` in protocol inheritance to avoid compiler warnings. ([#247](#247))
- Improve CI to test against multiple supported Xcode and Swift language versions.
- Restored test suite compatibility with Xcode 11.4 and Swift 5.2.
@gwhelanLD
Copy link
Contributor

This issue should be resolved in the 5.4.2 release. We've both update the swift-tools-version to prevent the test dependencies from being included transitively, as well as updated this dependency version for our tests.

Thanks for the report,
@gwhelanLD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants