This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't give up permanently after a 400 error
add brief Java compatibility note to readme
evaluate with an explanation - initial implementation
stop using deprecated TestFeatureStore in tests
avoid unnecessary retry after Redis update
…vents include explanations, if requested, in full feature request events
better error logging practices
…2124/filter-client-side-flags # Conflicts: # src/main/java/com/launchdarkly/client/LDClientInterface.java
…ithout-reasons add new version of allFlags() that captures more metadata
add error explanation and logging for malformed flags
…e-flags add ability to filter for only client-side flags
# Conflicts: # gradle.properties # src/main/java/com/launchdarkly/client/FeatureFlag.java # src/main/java/com/launchdarkly/client/LDClient.java # src/test/java/com/launchdarkly/client/LDClientEvaluationTest.java # src/test/java/com/launchdarkly/client/LDClientOfflineTest.java
# Conflicts: # src/main/java/com/launchdarkly/client/FeatureFlagsState.java # src/main/java/com/launchdarkly/client/FlagsStateOption.java # src/main/java/com/launchdarkly/client/LDClient.java # src/main/java/com/launchdarkly/client/LDClientInterface.java # src/test/java/com/launchdarkly/client/FeatureFlagsStateTest.java # src/test/java/com/launchdarkly/client/LDClientEvaluationTest.java # src/test/java/com/launchdarkly/client/LDClientOfflineTest.java
fix default value logic
avoid some inappropriate uses of Guava's ImmutableMap
…easons # Conflicts: # src/main/java/com/launchdarkly/client/FeatureFlagsState.java
don't keep evaluating prerequisites if one fails
add tests for JSON serialization of evaluation reasons
…ith-reasons evaluation reasons can be included in allFlagsState()
arun251
approved these changes
Aug 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
eli-darkly
added a commit
that referenced
this pull request
Aug 2, 2019
add Redis builder options for password, TLS, database
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.3.0] - 2018-08-27
Added:
LDClient
methodallFlagsState()
should be used instead ofallFlags()
if you are passing flag data to the front end for use with the JavaScript SDK. It preserves some flag metadata that the front end requires in order to send analytics events correctly. Versions 2.5.0 and above of the JavaScript SDK are able to use this metadata, but the output ofallFlagsState()
will still work with older versions.allFlagsState()
method also allows you to select only client-side-enabled flags to pass to the front end, by using the optionFlagsStateOption.CLIENT_SIDE_ONLY
. (#112)LDClient
methodsboolVariationDetail
,intVariationDetail
,doubleVariationDetail
,stringVariationDetail
, andjsonVariationDetail
allow you to evaluate a feature flag (using the same parameters as you would forboolVariation
, etc.) and receive more information about how the value was calculated. This information is returned in anEvaluationDetail
object, which contains both the result value and anEvaluationReason
which will tell you, for instance, if the user was individually targeted for the flag or was matched by one of the flag's rules, or if the flag returned the default value due to an error.Fixed:
LDUser.Builder
that would throw an exception if you initialized the builder by copying an existing user, and then tried to add a custom attribute.Deprecated:
LDClient.allFlags()