Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Conversation

@driverpt
Copy link

@driverpt driverpt commented Dec 31, 2021

Fixes #252

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

#252

Describe the solution you've provided

Adds Automatic-Module-Name to Gradle's Jar Task configuration so it's properly picked up by Jigsaw.

This will still need a proper module-info.java in the future, exposing only the public code. Internal should not be exposed

Describe alternatives you've considered

N/A

Additional context

https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_modular

@driverpt
Copy link
Author

UPDATE: This PR still does not solve it. Default Uber Jar generates a module-info.class with the following contents:

module com.google.gson {
  requires java.sql;
  requires jdk.unsupported;

  exports com.google.gson;
  exports com.google.gson.annotations;
  exports com.google.gson.reflect;
  exports com.google.gson.stream;
}

@eli-darkly
Copy link
Contributor

Closing this since it doesn't seem to be producing the desired result. Let's continue the discussion on the original issue #252.

@eli-darkly eli-darkly closed this Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proper module-info.java

2 participants