This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .circleci/config.yml # CONTRIBUTING.md
always use US locale when parsing HTTP dates
use Gson 2.8.9
don't try to send more diagnostic events after an unrecoverable HTTP error
ensure module-info file isn't copied into our jars during build
* test with Java 17 in CI * also test in Java 17 for Windows * fix choco install command
* fix suppression of nulls in JSON representations * distinguish between situations where we do or do not want to suppress nulls
…re's an experiment
fix identify/track null user key check, also don't create index event for alias
…iment fix setting of trackEvents/trackReason in allFlagsState data when there's an experiment
louis-launchdarkly
approved these changes
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[5.6.7] - 2022-01-28
Fixed:
before
andafter
date operators, if two ISO-8601 string values were compared that represented the exact same absolute date in different time zones (such as2000-01-01T08:00:00Z
and2000-01-01T00:00:00-08:00
), the SDK wrongly treated them as unequal. This did not affect strings that represented different absolute dates, which were always compared correctly. The SDK now handles both cases correctly.com.launchdarkly.sdk.json
serialization methods were sometimes omitting JSON object properties in cases where it would have been more correct to show the property with anull
value. This mainly affected JSON data produced byLDClient.allFlagsState()
, where the presence of a flag key with anull
value would indicate that the flag existed but could not be evaluated due to an error, as opposed to the flag not existing.