This repository has been archived by the owner on May 30, 2024. It is now read-only.
Update Javadoc when setting custom attributes for users. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should add in that runtime check / logging we discussed as part of this PR. |
…ibute. Fix formatting. Fix null check in user builder.
| @@ -0,0 +1,14 @@ | |||
| package com.launchdarkly.client; | |||
|
|
|||
| public enum UserAttribute { | |||
There was a problem hiding this comment.
I think this should have package level access.
|
👍 after changing the visibility of the new enum. |
| * @param k the key for the custom attribute | ||
| * Add a {@link java.lang.String}-valued custom attribute. | ||
| * | ||
| * @param k the key for the custom attribute. When set to one of the built-in user attribute keys, this custom attribute will be ignored. |
There was a problem hiding this comment.
Perhaps consider referencing the documentation directly on which keys are considered "built-in" (http://docs.launchdarkly.com/docs/targeting-users#targeting-based-on-user-attributes)?
Given that UserAttribute is package private it would be good to have an explicit reference to all attributes are considered "built in".
|
Yes-- let's reference the documentation here. |
…itted manual test file.
eli-darkly
added a commit
that referenced
this pull request
Mar 1, 2018
…-attrs avoid throw/catch when evaluating user attributes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Javadoc when setting custom attributes for users.