Skip to content

Commit

Permalink
fix: remove type modifiers on imports for better TS compatibility (#346)
Browse files Browse the repository at this point in the history
**Requirements**

- [ ] ~I have added test coverage for new or changed functionality~
- [x] I have followed the repository's [pull request submission
guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
- [ ] ~I have validated my changes against all supported platform
versions~

No new functionality has been added (only types import/export
refactoring).

**Related issues**

#345
#347

**Describe the solution you've provided**

Remove the usage of [type modifiers on import
names](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-5.html#type-modifiers-on-import-names)
to improve backwards compatibility with early versions of TypeScript.

**Describe alternatives you've considered**

The obvious solution would be upgrading the TypeScript version in the
consumer, but this is not always easy (it's not in our case). [More info
here](microsoft/TypeScript#25778).
  • Loading branch information
ismaelgt committed Jan 16, 2024
1 parent 4a6d4c3 commit 3506349
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/shared/common/src/internal/stream/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import StreamingProcessor from './StreamingProcessor';
import { type StreamingErrorHandler } from './types';
import type { StreamingErrorHandler } from './types';

export { StreamingProcessor, type StreamingErrorHandler };
export { StreamingProcessor };
export type { StreamingErrorHandler };

0 comments on commit 3506349

Please sign in to comment.