Skip to content

feat: add InternalClientProvider for Toolbar flags and analytics #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: add InternalClientProvider for Toolbar flags and analytics #288

wants to merge 9 commits into from

Conversation

@pranjal-jately-ld
Copy link
Contributor

@pranjal-jately-ld pranjal-jately-ld commented Nov 12, 2025 •
edited
Loading

Description

This PR adds support for an internal LaunchDarkly client within the toolbar package, enabling toolbar-specific feature flags and analytics tracking. The internal client is separate from the user's application client and can be optionally configured via environment variables.

What does this PR do?

  • Adds InternalClientProvider component to manage the toolbar's internal LaunchDarkly client
  • Implements createToolbarFlagFunction for type-safe access to toolbar feature flags
  • Adds support for configurable LaunchDarkly service URLs (base, stream, events) via environment variables
  • Updates build configuration to inject environment variables at build time
  • Adds comprehensive documentation for setting up the internal client configuration
  • Includes unit tests for the new provider and flag function

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation (changes to documentation only)
  • 🔧 Refactor (code change that neither fixes a bug nor adds a feature)
  • 🎨 Style (formatting, missing semicolons, etc; no production code change)
  • ⚡ Performance (code change that improves performance)
  • ✅ Test (adding missing tests, refactoring tests; no production code change)
  • 🔨 Chore (updating grunt tasks, build process, etc; no production code change)

Screenshots/Videos

@pranjal-jately-ld
feat: add InternalClientProvider for Toolbar flags and analytics
1ca2ebd 
- Introduced InternalClientProvider to manage the internal LaunchDarkly
client for toolbar features and analytics.
@pranjal-jately-ld
test: add unit tests for InternalClientProvider and createToolbarFlag…
11bb250 
…Function
@pranjal-jately-ld
refactor: add support for loading env vars in toolbar
59d4f90 
- Added support for loading environment variables with the TOOLBAR_
prefix in the toolbar configuration files.
- Introduced a new vite-env.d.ts file to define environment variable
types for better TypeScript support.
@pranjal-jately-ld
feat: add support for configurable base, stream and events url for in…
3dfe4f7 
…ternal client

- Added support for TOOLBAR_INTERNAL_BASE_URL, TOOLBAR_INTERNAL_STREAM_URL,
and TOOLBAR_INTERNAL_EVENTS_URL in the toolbar configuration.
@pranjal-jately-ld
docs: update CONTRIBUTING.md to include optional toolbar internal con…
14f7455 
…fig instructions
@pranjal-jately-ld
refactor: update AnalyticsProvider to use internal client instance
e506011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pranjal-jately-ld