Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add build script to auto generate types.ts #1064

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthewferry
Copy link
Contributor

Summary

This is just a WIP of adding some tooling around icons. I've had to add/update a bunch lately and the process is pretty manual and a little error-prone. It would be possible to write a script to pull the icon components out of figma, run SVGO on them, concat them into the sprite and add the id to the icon type definition.

  • Figma API to get icons from launchpad
  • Run svgo on the paths—remove colors, set standard viewbox, remove attributes, etc
  • concat into sprite
  • add to type definition

@Niznikr this isn't high priority and this code is questionable (didn't write it in typescript or really think it through much), but just something I whipped up to make adding icons yesterday faster. curious your thoughts

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: d470229

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant