Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventSource emits events out of order #19

Closed
chirino opened this issue Apr 13, 2017 · 1 comment
Closed

EventSource emits events out of order #19

chirino opened this issue Apr 13, 2017 · 1 comment

Comments

@chirino
Copy link
Contributor

chirino commented Apr 13, 2017

I think it would be better if a Executors.newSingleThreadExecutor() was used instead of a Executors.newCachedThreadPool() executor so that the events created by the EventSource could arrive to the handler in order.

Right now it's possible to get an onMessage before an onOpen.
chirino added a commit to chirino/okhttp-eventsource that referenced this issue Apr 13, 2017
@chirino
Fixes issue launchdarkly#19 - EventSource emits events out of order
3cbddfd
drichelson added a commit that referenced this issue Apr 28, 2017
@drichelson
Merge pull request #20 from chirino/master
96a89fc 
Fixes issue #19 - EventSource emits events out of order
@arun251
Copy link
Contributor

arun251 commented Jun 28, 2017

The fix for this issue should have been released in version 1.3.2.

@arun251 arun251 closed this as completed Jun 28, 2017
eli-darkly added a commit that referenced this issue Dec 13, 2018
@eli-darkly
Merge pull request #19 from launchdarkly/eb/ch28144/okhttp-url
1bd8145 
allow endpoint to be specified as either URI or HttpUrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chirino @arun251