prepare 6.8.4 release #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add option to reduce front-end metadata for untracked flags
fix logic for whether a flag is tracked in all_flags_state
use expiringdict from PyPi
implement file data source
Hr/azurepytest
don't load test dependencies in Python 3.3 that don't work in Python 3.3
… without valid users
coerce user attributes into strings when necessary, don't send events without valid users
torchhound
reviewed
Mar 29, 2019
|
|
||
| __USER_ATTRS_TO_STRINGIFY_FOR_EVALUATION__ = [ "key", "secondary" ] | ||
| # Currently we are not stringifying the rest of the built-in attributes prior to evaluation, only for events. | ||
| # This is because it could affect evaluation results for existing users (ch35206). |
There was a problem hiding this comment.
Should we expose a clubhouse ticket number?
Contributor
Author
There was a problem hiding this comment.
I don't see why not. It's not sensitive information and it may be helpful to us later.
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 30, 2019
(re)implement setting proxy URL by environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[6.8.4] - 2019-03-29
Fixed:
trackoridentifyis called without a user, the SDK now logs a warning, and does not send an analytics event to LaunchDarkly (since it would not be processed without a user).