Stream and polling processor logging updates to warn on recoverable errors #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fritzdj thank you for this contribution. These changes look good to me. Can you also update the behavior in the polling processor so the behavior stays consistent between the two data sources? Thank you! |
@keelerm84, thanks for the review! I just pushed the same change for |
fritzdj
changed the title
fritzdj
changed the title
fritzdj
changed the title
keelerm84
approved these changes
Sep 6, 2023
Merged
LaunchDarklyReleaseBot
pushed a commit
that referenced
this pull request
Sep 6, 2023
Our documentation file had a configuration issue, which emits a warning when building with sphinx. This caused the build process on readthedocs.org to fail because they treat warnings as errors. We didn't catch this because: 1. Warnings are treated like warnings when generating documentation locally. 2. We don't try to generate the documentation as part of our CI process. This commit should resolve both the underlying issue and the deficiencies that prevented us from catching this initially.
LaunchDarklyReleaseBot
added a commit
that referenced
this pull request
Sep 6, 2023
## [8.1.6] - 2023-09-06 ### Changed: - Recoverable errors are logged as a warning not an error. (Thanks, [fritzdj](#219)!) --------- Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Eli Bishop <eli@launchdarkly.com> Co-authored-by: LaunchDarklyCI <dev@launchdarkly.com> Co-authored-by: LaunchDarklyCI <LaunchDarklyCI@users.noreply.github.com> Co-authored-by: hroederld <hroeder@launchdarkly.com> Co-authored-by: Robert J. Neal <rneal@launchdarkly.com> Co-authored-by: Robert J. Neal <robertjneal@users.noreply.github.com> Co-authored-by: Ember Stevens <ember.stevens@launchdarkly.com> Co-authored-by: ember-stevens <79482775+ember-stevens@users.noreply.github.com> Co-authored-by: Matthew M. Keeler <keelerm84@gmail.com> Co-authored-by: charukiewicz <charukiewicz@protonmail.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Christian Charukiewicz <christian@foxhound.systems> Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com> Co-authored-by: Elliot <35050275+Apache-HB@users.noreply.github.com> Co-authored-by: Gabor Angeli <gabor@squareup.com> Co-authored-by: Elliot <apachehaisley@gmail.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: prpnmac <95777763+prpnmac@users.noreply.github.com> Co-authored-by: Louis Chan <91093020+louis-launchdarkly@users.noreply.github.com> Co-authored-by: Daniel Fritz <dfritz@indigoag.com>
|
Fixed in 8.1.6 And once again, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using a logging integration for internal alerting and we want to be able to filter out certain error logs where the LD client is running into a "recoverable" error if possible. Today we noticed there were HTTP responses with a 500 status being returned when StreamingUpdateProcessor was running -- this looked to be a minor blip. Could we log these at the warning level instead of the error level if these are 'expected' blips?