This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
813fe02
commit 6d356bf
Showing
7 changed files
with
18 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
node_modules/ | ||
npm-debug.log | ||
yarn-error.log | ||
target/ | ||
|
||
# Xcode | ||
# | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,4 @@ template: | |
name: npm | ||
|
||
sdk: | ||
displayName: React Native | ||
displayName: React Native |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,30 @@ | ||
Contributing to the LaunchDarkly Client-side SDK for React Native | ||
================================================ | ||
|
||
LaunchDarkly has published an [SDK contributor's guide](https://docs.launchdarkly.com/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work. See below for additional information on how to contribute to this SDK. | ||
|
||
Submitting bug reports and feature requests | ||
------------------ | ||
|
||
The LaunchDarkly SDK team monitors the [issue tracker](https://github.com/launchdarkly/react-native-client-sdk/issues) in the SDK repository. Bug reports and feature requests specific to this SDK should be filed in this issue tracker. The SDK team will respond to all newly filed issues within two business days. | ||
|
||
Submitting pull requests | ||
------------------ | ||
|
||
We encourage pull requests and other contributions from the community. Before submitting pull requests, ensure that all temporary or unintended code is removed. Don't worry about adding reviewers to the pull request; the LaunchDarkly SDK team will add themselves. The SDK team will acknowledge all pull requests within two business days. | ||
|
||
Build instructions | ||
------------------ | ||
|
||
### Prerequisites | ||
|
||
This SDK requires that you have [`npm`](https://www.npmjs.com/) and [`react-native-cli`](https://www.npmjs.com/package/react-native-cli) installed in order to develop with it. | ||
|
||
### Building and running | ||
|
||
You can modify and verify changes by developing within the LaunchDarkly React Native SDK sample application (`hello-react-native`). | ||
|
||
1. In your `react-native-client-sdk` directory, run `npm link`. | ||
2. Clone and setup the [`hello-react-native`](https://github.com/launchdarkly/hello-react-native) repository. | ||
3. In your `hello-react-native` directory, copy your `react-native-client-sdk` into `node_modules` or use [wml](https://github.com/wix/wml) to monitor and copy files. | ||
1. Clone and setup the [`hello-react-native`](https://github.com/launchdarkly/hello-react-native) repository. | ||
2. In your `hello-react-native` directory, copy your `react-native-client-sdk` directory into `node_modules` as `launchdarkly-react-native-client-sdk`. Alternatively, you can use [wml](https://github.com/wix/wml) to monitor and copy files. | ||
3. Launch your emulator (`emulator -avd <NAME>` for Android) or connect your device. | ||
4. Test your changes in `hello-react-native` by running either `react-native run-ios` or `react-native run-android` depending on your desired runtime environment. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
<manifest package="com.reactlibrary"> | ||
<manifest package="com.launchdarkly.reactnative"> | ||
|
||
</manifest> |
2 changes: 1 addition & 1 deletion
2
.../LaunchdarklyReactNativeClientModule.java → .../LaunchdarklyReactNativeClientModule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...LaunchdarklyReactNativeClientPackage.java → ...LaunchdarklyReactNativeClientPackage.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters