Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Add privateAttributeNames as available field on LDConfig #102

Closed
mathvbarone opened this issue Nov 29, 2021 · 3 comments
Closed

Add privateAttributeNames as available field on LDConfig #102

mathvbarone opened this issue Nov 29, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@mathvbarone
Copy link

mathvbarone commented Nov 29, 2021

Is it possible to have the field privateAttributeNamesavailable when creating an instance of the client, so it gets propagated for all users sharing the same instance? It would be similar to how it works for JS API on LDOptions.

Check the example below:

const user = { key: "new-user" }
const config = { privateAttributeNames: ["name", "email"] }
try {
  await client.configure(config, user);
  return client;
} catch (err) {
  console.error(err)
}

Thanks in advance!

@gwhelanLD
Copy link
Contributor

Hi @mathvbarone,

Thanks for the feature suggestion! I've filed it internally, and we'll try to get to it soon.

Thanks,
@gwhelanLD

@louis-launchdarkly
Copy link
Contributor

The ticket was filed when @gwhelanLD replied above, add the reference here for tracking:

Filed Internally as 133931

LaunchDarklyReleaseBot pushed a commit that referenced this issue Jan 21, 2022
[SC 137578] Remove the JCenter usage in Gradle
@louis-launchdarkly louis-launchdarkly added the enhancement New feature or request label Feb 18, 2022
louis-launchdarkly pushed a commit that referenced this issue Feb 26, 2022
### Added:
- Added `privateAttributeNames` configuration option for `LDConfig` allowing the configuration of private attributes for all users. ([#102](#102))

### Fixed:
- Android: Updated Android SDK dependency to [3.1.3](https://github.com/launchdarkly/android-client-sdk/releases/tag/3.1.3).
- Android: Added missing native module API stubs to prevent warning on `NativeEventEmitter`. ([#116](#116))
- iOS: Fixed ownership handling of native callbacks to avoid garbage collection of all flags and connection mode listeners that are still in use. ([#106](#106))
@gwhelanLD
Copy link
Contributor

gwhelanLD commented Feb 26, 2022

This is now available in the 6.1.0 release, thanks again for the suggestion!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants