This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 32
6.2.3 is completely broken on Android #157
Labels
bug
Something isn't working
Comments
Same issue. |
Hello @i1skn and @mfelix5, thank you for reporting this issue - this is a serious issue and we are looking into it - for unblocking the people using this, we are looking to first revert this part of the We will update this when we have a release. |
Merged
@louis-launchdarkly thanks so much for such a quick fix! Seems like both issues were fixed in 6.2.4! |
LaunchDarklyReleaseBot
pushed a commit
that referenced
this issue
Jun 22, 2023
This is a bugfix for the publicly submitted issue: #160 where `getLastSuccessfulConnection` and `getLastFailedConnection` can result in a null exception. --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
6.2.3 is completely broken for Android
To reproduce
Launch
ManualTestApp
on Android using 6.2.3Observe in console
ERROR [Error: LaunchDarkly SDK already initialized]
immediately after run.Expected behavior
Calling
.configure(...)
should not resolve into anLaunchDarkly SDK already initialized
error neither at the start of the app, nor after we call.close()
and then.configure(...)
again.SDK version
6.2.3
OS/platform
Android 12
Additional context
This happens because
.isInitialized(...)
used to return a rejected Promise, when client is not available and since 6.2.3 (as pointed here) it resolves withfalse
.If you look on the code below, you'll see, that if
.isInitialized(...)
is not rejected -> we throw an error, but right we do not reject it, hence we see a vicious cycle.On 6.2.2
.isInitialized(...)
would resolve withfalse
after you've called.close()
instead of rejecting (see here this issue).So, 6.2.3 is completely unusable on Android.
react-native-client-sdk/index.js
Lines 21 to 43 in 0754d67
The text was updated successfully, but these errors were encountered: