This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
prepare 6.2.1 release #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to iOS 5.4.0 (#48) * Bump iOS SDK version to 5.4.0 * Replace shared with get() * Replace old method names * Provide default values for EvaluationDetail * Fixed defaultValue for detail value * Changed individual nil coalesce to NSNull * Remove isDisableBackgroundPolling method (#52) * Update iOS base url (#49) * Update iOS base url * Added wrapper name and version to iOS and Android config (#50) * Added wrapper name and version to iOS and Android config * V4 not 5 * Rename wrapper * Add getVersion method (#51) * Added getVersion method * Revert package.json version bump * Fix version case Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Rename fallback to defaultValue (#53) * Rename fallback to defaultValue * Fix awkward wording defaultValue value * Fix defaultValue value line breaks * Improved resiliency when running in Android (#54) * Add new config values (#55) * Added new config values to iOS and Android * Added typescript config * PR feedback * Fix millis, add default doc * fix common build + add tests for recent introductions (#56) * fix: start background thread for identify rather than running it (#66) * Bump Android SDK version to 2.14.1 (#59) * Update Android to 2.14.1, change setBaseUri to setPollUri, change floatVariation to doubleVariation * Fix float to double * Doublevalue on non detail * Run CI against v4.0 * URL fix iOS * Add isInitialized to iOS, check initialization in configure (#60) * Added isInitialized to iOS * Add init check to configure * Base url iOS fix, v4.0 ci * Var not func iOS, remove getMap * disable auto-alias in iOS (#61) * Add configureWithTimeout method (#58) * Added configureTimeout method * Fix timeout type on iOS * Simplify timeout nil check * Added param labels, Java syntax fixes * Small fixes * Make timeout final * Remove unnecessary catch * Fix baseUrl * Fix Android config error * Test against v4.0 hello branch * Fix tests * timeout never nil inside check * Convert Int to TimeInterval * Fixed iOS startWaitSeconds * Catch LDException * Fix merge conflict in iOS bridge * Fix merge conflict in index.js * PR feedback * Fix unused timeoutClient * Remove unnecessary ConfigEntryType * Remove StringSet * If let in timeout check * Configure method now takes optional timeout parameter instead of separate method * Renames for consistency (#62) * up-leveling the override for the default polling uri so it affects android too (#63) * Added ip, avatar, and allUserAttributesPrivate (#57) * Added ip, avatar, and allUserAttributesPrivate * Updated test-types.ts, fix case typo * Special case allUserAttributesPrivate * Fix ReadableMap loading of all private * CI fix * Fix string to URL baseUrl * Change to non-default values in test, combine lines in config.yml * Simplify allAttrsPrivate if * resolve breakage with latest merge Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> * Added accessor methods for ConnectionInformation (#64) * Added ConnectionInformation accessors * Fixes from manual testing * PR feedback * Fix allUserAttributesPrivate * Improve typescript docs * Minor fixes (#66) Fixes `floatVariation` to keep double precision and fix build warnings. * Fix track metricValue on iOS (#67) * Remove CI checkout for release Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Ed Costello <orthanc@users.noreply.github.com> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> Co-authored-by: Gavin Whelan <gwhelan@launchdarkly.com>
…VariationDetailNone (#73)
…e-client-sdk-private
…ing (#74) * Added ts flag for testing * Testing bwoskow typescript enum patch * Remove todo
* Update to iOS 5.4.0 (#48) * Bump iOS SDK version to 5.4.0 * Replace shared with get() * Replace old method names * Provide default values for EvaluationDetail * Fixed defaultValue for detail value * Changed individual nil coalesce to NSNull * Remove isDisableBackgroundPolling method (#52) * Update iOS base url (#49) * Update iOS base url * Add protocol * Added wrapper name and version to iOS and Android config (#50) * Added wrapper name and version to iOS and Android config * V4 not 5 * Rename wrapper * Add getVersion method (#51) * Added getVersion method * Revert package.json version bump * Fix version case * Fix minor PR feedback * Update index.d.ts Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> * Rename fallback to defaultValue (#53) * Rename fallback to defaultValue * Fix awkward wording defaultValue value * Fix defaultValue value line breaks * Improved resiliency when running in Android (#54) * Add new config values (#55) * Added new config values to iOS and Android * Added typescript config * PR feedback * Fix millis, add default doc * fix common build + add tests for recent introductions (#56) * Added secondaryMobileKeys and getForMobileKey * Added primaryEnvironmentName constant * Fix Android build errors * Fix build errors * Fix Android config error * CI test fixes * Catch LD exception without crashing * fix: start background thread for identify rather than running it (#66) * Bump Android SDK version to 2.14.1 (#59) * Update Android to 2.14.1, change setBaseUri to setPollUri, change floatVariation to doubleVariation * Fix float to double * Doublevalue on non detail * Run CI against v4.0 * URL fix iOS * Add isInitialized to iOS, check initialization in configure (#60) * Added isInitialized to iOS * Add init check to configure * Base url iOS fix, v4.0 ci * Var not func iOS, remove getMap * disable auto-alias in iOS (#61) * Add configureWithTimeout method (#58) * Added configureTimeout method * Fix timeout type on iOS * Simplify timeout nil check * Added param labels, Java syntax fixes * Small fixes * Make timeout final * Remove unnecessary catch * Fix baseUrl * Fix Android config error * Test against v4.0 hello branch * Fix tests * timeout never nil inside check * Convert Int to TimeInterval * Fixed iOS startWaitSeconds * Catch LDException * Fix merge conflict in iOS bridge * Fix merge conflict in index.js * PR feedback * Fix unused timeoutClient * Remove unnecessary ConfigEntryType * Remove StringSet * If let in timeout check * Configure method now takes optional timeout parameter instead of separate method * Renames for consistency (#62) * up-leveling the override for the default polling uri so it affects android too (#63) * Added ip, avatar, and allUserAttributesPrivate (#57) * Added ip, avatar, and allUserAttributesPrivate * Updated test-types.ts, fix case typo * Special case allUserAttributesPrivate * Fix ReadableMap loading of all private * CI fix * Fix string to URL baseUrl * Change to non-default values in test, combine lines in config.yml * Simplify allAttrsPrivate if * resolve breakage with latest merge Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com> * Multi environment works in Android, fixed bad config type * Fix allUserAttributesPrivate * Fix typescript test * No StringSet for wrapper, change to ldClient for isInitialized * Forgot nil check * environment param * Select environment via method parameter * Check for environment undefined in JS * iOS error fixes * Fix iOS bridge, add missing param and try to Android * Remove v4.0 branch hello rn for CI * Fixed all flags and better long conversion * A bunch of let to const, change default to test in multi env ts test, remove ldClient var from iOS * Remove internal comments from Android * Added back 2 Android comments, Double to NSNumber reversion, var to let reversion, ternary to function * Get default environment name from underlying SDKs * Cast NSNumber to Double to fix compilation error * getVersion public, remove ldClient from Android * Use get() * Remove unnecessary get() * Try instead of null check * as! Double to doubleValue, toIntExact to intValue, change Android env name, improve try * Fix listeners in multiple environments, change continue to comment in Android try/catch init * Add semicolon in between environment and flagKey or listenerId string concat * Environment concatenation function * Swift param labels * Added self, remove conditional cast to Any * Remove unnecessary nil coalescing * Capitalize ldClient * getForMobileKey Android * Removed unnecessary try, added final keyword * Revert some nonnull and Double types * Inline primaryEnvironmentName iOS Co-authored-by: Ben Woskow <48036130+bwoskow-ld@users.noreply.github.com> Co-authored-by: Ben Woskow <bwoskow@launchdarkly.com>
* remove platform specific default env name * Replace function with ternary * Remove _getEnvironment
Handle promise from `isInitialized` during configuration. Update iOS `isInitialized` to reject when not configured to match Android implementation. Improve Android `allFlags` to reject promise when non-existent environment is used or other exception, and allow calling `allFlags` before client initialization completes.
Releasing 4.0.4
Update ManualTestApp to the correct variation method
…s-readme Update supported RN versions in readme.
…us are unspecified (#124)
Bump Android SDK to 3.1.6
aengelberg
approved these changes
Aug 2, 2022
LaunchDarklyReleaseBot
pushed a commit
that referenced
this pull request
Mar 2, 2023
* Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com>
yusinto
added a commit
that referenced
this pull request
Mar 2, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com>
yusinto
added a commit
that referenced
this pull request
Mar 2, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com>
yusinto
added a commit
that referenced
this pull request
Mar 3, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com>
yusinto
added a commit
that referenced
this pull request
Mar 6, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-186949] Add support for RN 0.71.x (#147) * [sc-186949] Support RN 0.71 * Update project.pbxproj * Fixed android build for 0.71.x * Update sdk android gradle plugin to 7.4.2 and restore allprojects settings to fix local build. * Update build.gradle * Remove allprojects again to fix Example app's build. Local build becomes broken again, and it needs to be fixed. * Fixed android local dev build * Remove all xcode versions but one * Attempt to fix ruby ci error. Deleted patches dir. * Update config.yml * Update config.yml * Update config.yml * Remove .ruby-version to use os default * PR feedback * Corrected include to be exclude * Remove xcode 13 from circleci build --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com>
yusinto
added a commit
that referenced
this pull request
Mar 6, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-186949] Add support for RN 0.71.x (#147) * [sc-186949] Support RN 0.71 * Update project.pbxproj * Fixed android build for 0.71.x * Update sdk android gradle plugin to 7.4.2 and restore allprojects settings to fix local build. * Update build.gradle * Remove allprojects again to fix Example app's build. Local build becomes broken again, and it needs to be fixed. * Fixed android local dev build * Remove all xcode versions but one * Attempt to fix ruby ci error. Deleted patches dir. * Update config.yml * Update config.yml * Update config.yml * Remove .ruby-version to use os default * PR feedback * Corrected include to be exclude * Remove xcode 13 from circleci build --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Merging public changes --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com>
yusinto
added a commit
that referenced
this pull request
Mar 6, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-186949] Add support for RN 0.71.x (#147) * [sc-186949] Support RN 0.71 * Update project.pbxproj * Fixed android build for 0.71.x * Update sdk android gradle plugin to 7.4.2 and restore allprojects settings to fix local build. * Update build.gradle * Remove allprojects again to fix Example app's build. Local build becomes broken again, and it needs to be fixed. * Fixed android local dev build * Remove all xcode versions but one * Attempt to fix ruby ci error. Deleted patches dir. * Update config.yml * Update config.yml * Update config.yml * Remove .ruby-version to use os default * PR feedback * Corrected include to be exclude * Remove xcode 13 from circleci build --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Merging public changes * [sc-191407] Update supported versions on README (#148) * Update README.md * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com>
yusinto
added a commit
that referenced
this pull request
Mar 15, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-186949] Add support for RN 0.71.x (#147) * [sc-186949] Support RN 0.71 * Update project.pbxproj * Fixed android build for 0.71.x * Update sdk android gradle plugin to 7.4.2 and restore allprojects settings to fix local build. * Update build.gradle * Remove allprojects again to fix Example app's build. Local build becomes broken again, and it needs to be fixed. * Fixed android local dev build * Remove all xcode versions but one * Attempt to fix ruby ci error. Deleted patches dir. * Update config.yml * Update config.yml * Update config.yml * Remove .ruby-version to use os default * PR feedback * Corrected include to be exclude * Remove xcode 13 from circleci build --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Merging public changes * [sc-191407] Update supported versions on README (#148) * Update README.md * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * fix: 7.x startup crash due to missing proguard file (#152) * fix: startup crash due to missing proguard file * remove hardcoded simulator uuid * Update Podfile.lock * reinstate local package link * add separate android-release command --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com>
LaunchDarklyReleaseBot
added a commit
that referenced
this pull request
Mar 21, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-186949] Add support for RN 0.71.x (#147) * [sc-186949] Support RN 0.71 * Update project.pbxproj * Fixed android build for 0.71.x * Update sdk android gradle plugin to 7.4.2 and restore allprojects settings to fix local build. * Update build.gradle * Remove allprojects again to fix Example app's build. Local build becomes broken again, and it needs to be fixed. * Fixed android local dev build * Remove all xcode versions but one * Attempt to fix ruby ci error. Deleted patches dir. * Update config.yml * Update config.yml * Update config.yml * Remove .ruby-version to use os default * PR feedback * Corrected include to be exclude * Remove xcode 13 from circleci build --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Merging public changes * [sc-191407] Update supported versions on README (#148) * Update README.md * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * fix: 7.x startup crash due to missing proguard file (#152) * fix: startup crash due to missing proguard file * remove hardcoded simulator uuid * Update Podfile.lock * reinstate local package link * add separate android-release command --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Bumped launchdarkly-android-client-sdk to include bugfix Bumping launchdarkly-android-client-sdk to 4.2.1 to include fix for bug sc-191967 --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: tanderson-ld <127344469+tanderson-ld@users.noreply.github.com>
yusinto
added a commit
that referenced
this pull request
Apr 6, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-186949] Add support for RN 0.71.x (#147) * [sc-186949] Support RN 0.71 * Update project.pbxproj * Fixed android build for 0.71.x * Update sdk android gradle plugin to 7.4.2 and restore allprojects settings to fix local build. * Update build.gradle * Remove allprojects again to fix Example app's build. Local build becomes broken again, and it needs to be fixed. * Fixed android local dev build * Remove all xcode versions but one * Attempt to fix ruby ci error. Deleted patches dir. * Update config.yml * Update config.yml * Update config.yml * Remove .ruby-version to use os default * PR feedback * Corrected include to be exclude * Remove xcode 13 from circleci build --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Merging public changes * [sc-191407] Update supported versions on README (#148) * Update README.md * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * fix: 7.x startup crash due to missing proguard file (#152) * fix: startup crash due to missing proguard file * remove hardcoded simulator uuid * Update Podfile.lock * reinstate local package link * add separate android-release command --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Bumped launchdarkly-android-client-sdk to include bugfix Bumping launchdarkly-android-client-sdk to 4.2.1 to include fix for bug sc-191967 --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: tanderson-ld <127344469+tanderson-ld@users.noreply.github.com>
yusinto
added a commit
that referenced
this pull request
Apr 6, 2023
* [sc-190014] Merge 7.0 for u2c release (#143) * Update swift and android sdk dependencies * Initial commit * TODO: comment out private attributes config and figure out later * Remove erroneous type annotation * TODO: fix deprecated config settings * Added todos to map deprecated android config * Initial refactor to move deprecated android config items * Start implementing deprecated config options * Implement android sdk major changes * Removed deprecated config options * Remove pollUri to use streaming and default endpoints * Implemented typescript changes * Renamed xxxUri to xxxUrl * Implemented swift config option changes * Fixed Reference creation for private context attributes * Update modd.conf * Removed jcenter * Reinstate user.privateAttributeNames because that should stay frozen * PR feedback * Update test-types.ts * Remove unnecessary stream: true config default * [sc-188224] Adios old rn versions * Set example app min ios target to 12.4 as mandated by rn 0.70. Improve local dev modd experience. * Added yarn-all scripts * Fixed broken tests by adding babel config and removing redundant transform.js * Remove old rn versions from CI * Force npm i to get around rn 6.3.0 still supporting old rn versions * Increase circleci macos resource to large * [sc-188335] Add u2c support (#140) * Added js common sdk context helper files. First attempt to implement glue code from js to android sdk. * Validate context in js before initializing ldclient * Added multi context support. Dry'd context manipulation logic. * Copy src folder to node_modules so its part of the npm package * Added arbitrary attributes mapping logic * Replaced src/common sdk files with actual js common sdk package * Refactored init code to be more robust with errors. Dry'd init logic. * Implemented identify logic for context. Changed example app to use multi context. * Autogenerate keys for anonymous context * Removed console logs and dry'd logic * Added contextUtils. Refactored isContext to js. * Initial attempt at ios context implementation * First cut ios implementation * Refactored helper functions to its own utils class. Added android unit tests. * Added multicontext tests * Added ios Podfile and fix dev build. Added swift unit tests. * Added swift unit test scaffold * Update Tests.swift * Improve ios unit tests * Speed up hot reload by replacing cp with rsync. Dry'd dir paths eliminating repetitions. * Update Tests.swift * Update .gitignore * Added more context and config tests * Add unit test for config build * Update modd-android.conf * Added contextUtils tests * Added typescript support for example app to test types. Replaced cp with rsync to speed up local dev. Improved tsconfig to use out of the box rn config. * Use common types for LDUser, LDContext and LDMultiKindContext * Update LaunchdarklyReactNativeClient.xcscheme * Update App.tsx * Prettified changelog * Updated common sdk version * Replaced user references with context * Use trySetValue for key, name and anonymous * Update config.yml * Added files property to specify only necessary files for npm publish * Exclude android test files from npm publish * Replace print with NSLog * Revert prettier changes. Ignore changelog from prettier. * Corrected misspelling of filename. * Added newline at eof * [sc-189696] Fix auto generation of anonymous keys (#141) * Initial commit * Rollback swift changes * Swift changes. * Updated js tests * Don't generate keys in js and defer context validation to native sdks * Update Tests.swift * Add java anonymous key test * Add github actions for tests * Update main.yml * Remove js tests from cicleci to github action. Prettified circleci config. * Update config.yml * Update config.yml * Update config.yml * Update config.yml * Add ios test job * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Cache pods and quiet xcodebuild * Update main.yml * Update main.yml * Update main.yml * Update main.yml * Restore other tests --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Fixed formatting of ga yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-169352] Add ldClient nil guards (#142) Update LaunchdarklyReactNativeClient.swift * Attempt to fix broken ios tests * Bust Pod cache * Update config.yml --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-190127] Update npm package-lock (#144) * [sc-190127] Update npm package-lock * Update pod cache key * Update yarn.lock * Update yarn.lock * Update yarn.lock * Update package.json * Downgrade typescript version to fix typedoc issues * Update main.yml * Bump rn sdk to v7 * [sc-178013] Add android null guards for LDClient (#145) * Bump rn sdk to v7 * [sc-178013] Add null guards for LDClient * Improved warning messages * Update LaunchdarklyReactNativeClientModule.java --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Update yarn.lock * [sc-190944] Add dotenv variable for example app (#146) * [sc-190944] Add dotenv to example app * Ignore .env files * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * [sc-186949] Add support for RN 0.71.x (#147) * [sc-186949] Support RN 0.71 * Update project.pbxproj * Fixed android build for 0.71.x * Update sdk android gradle plugin to 7.4.2 and restore allprojects settings to fix local build. * Update build.gradle * Remove allprojects again to fix Example app's build. Local build becomes broken again, and it needs to be fixed. * Fixed android local dev build * Remove all xcode versions but one * Attempt to fix ruby ci error. Deleted patches dir. * Update config.yml * Update config.yml * Update config.yml * Remove .ruby-version to use os default * PR feedback * Corrected include to be exclude * Remove xcode 13 from circleci build --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Merging public changes * [sc-191407] Update supported versions on README (#148) * Update README.md * Update README.md --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * fix: 7.x startup crash due to missing proguard file (#152) * fix: startup crash due to missing proguard file * remove hardcoded simulator uuid * Update Podfile.lock * reinstate local package link * add separate android-release command --------- Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> * Bumped launchdarkly-android-client-sdk to include bugfix Bumping launchdarkly-android-client-sdk to 4.2.1 to include fix for bug sc-191967 * fix: typescript and lint errors in example app * fix: yarn.lock conflict with public --------- Co-authored-by: Yusinto Ngadiman <yusinto@gmail.com> Co-authored-by: Yusinto Ngadiman <yus@launchdarkly.com> Co-authored-by: LaunchDarklyReleaseBot <launchdarklyreleasebot@launchdarkly.com> Co-authored-by: Louis Chan <lchan@launchdarkly.com> Co-authored-by: tanderson-ld <127344469+tanderson-ld@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[6.2.1] - 2022-08-02
Fixed: