prepare 6.3.0 release

.circleci/config.yml

@@ -49,6 +49,16 @@ jobs:
             mkdir -p test
             cd test
             [ -d "CITest" ] || npx react-native@<<parameters.rn-version>> init CITest --version <<parameters.rn-version>> --skip-install
+
+            # HACK: rn 0.64.x init the test project targeting ios 10, which is incompatible with the ios SDK which requires
+            # a minimum of ios 11
+            sed -i.bak "s/platform :ios, '10.0'/platform :ios, '11.0'/" CITest/ios/Podfile
+            sed -i.bak "s/IPHONEOS_DEPLOYMENT_TARGET = 10.0;/IPHONEOS_DEPLOYMENT_TARGET = 11.0;/" CITest/ios/CITest.xcodeproj/project.pbxproj
+
+            #HACK: force rn android 0.64.x init to use minSdkVersion 30 to pass the build
+            sed -i.bak 's/buildToolsVersion = "29.0.3"/buildToolsVersion = "30.0.2"/' CITest/android/build.gradle
+            sed -i.bak "s/compileSdkVersion = 29/compileSdkVersion = 31/" CITest/android/build.gradle
+            sed -i.bak "s/targetSdkVersion = 29/targetSdkVersion = 31/" CITest/android/build.gradle
 
       - save_cache:
           name: Save RN project template to cache
@@ -141,12 +151,12 @@ workflows:
           name: rn<<matrix.rn-version>>-xc<<matrix.xcode-version>>-build-apps-using-template
           matrix:
             parameters:
-              rn-version: ["0.64.3", "0.65.2", "0.66.4", "0.67.3", "0.68.0","0.69.4", "0.70.1"]
-              xcode-version: ["12.5.1", "13.2.1", "13.4.1", "14.0.1"]
+              rn-version: [ "0.64.4", "0.65.2", "0.66.4", "0.67.3", "0.68.0","0.69.4", "0.70.1" ]
+              xcode-version: [ "12.5.1", "13.2.1", "13.4.1", "14.0.1" ]
             exclude:
-              - rn-version: "0.64.3"
+              - rn-version: "0.64.4"
                 xcode-version: "13.4.1"
-              - rn-version: "0.64.3"
+              - rn-version: "0.64.4"
                 xcode-version: "14.0.1"
               - rn-version: "0.65.2"
                 xcode-version: "13.4.1"

.prettierrc

@@ -0,0 +1,6 @@
+{
+  "singleQuote": true,
+  "trailingComma": "all",
+  "printWidth": 120,
+  "arrowParens": "always"
+}

CODEOWNERS

@@ -0,0 +1 @@
+* @kinyoklion @yusinto @louis-launchdarkly

ManualTestApp/.prettierrc

@@ -0,0 +1,6 @@
+{
+  "singleQuote": true,
+  "trailingComma": "all",
+  "printWidth": 120,
+  "arrowParens": "always"
+}

ManualTestApp/App.js

@@ -1,31 +1,20 @@
 import React, { useState, useEffect } from 'react';
-import { SafeAreaView,
-         ScrollView,
-         StyleSheet,
-         Text,
-         View,
-         Button,
-         TextInput,
-         Alert,
-         Switch,
-       } from 'react-native';
+import { SafeAreaView, ScrollView, StyleSheet, Text, View, Button, TextInput, Alert, Switch } from 'react-native';
 import { Picker } from '@react-native-picker/picker';
 import LDClient from 'launchdarkly-react-native-client-sdk';
 import MessageQueue from 'react-native/Libraries/BatchedBridge/MessageQueue.js';
 
-const Wrapper = ({children}): Node => {
+const Wrapper = ({ children }): Node => {
   const styles = {
     scroll: { backgroundColor: '#fff', padding: 10 },
     area: { backgroundColor: '#fff', flex: 1 },
   };
   return (
     <SafeAreaView style={styles.area}>
-      <ScrollView style={styles.scroll}>
-        {children}
-      </ScrollView>
+      <ScrollView style={styles.scroll}>{children}</ScrollView>
     </SafeAreaView>
   );
-}
+};
 
 const Body = () => {
   const [client, setClient] = useState(null);
@@ -42,6 +31,10 @@ const Body = () => {
       let config = {
         mobileKey: 'MOBILE_KEY',
         debugMode: true,
+        application: {
+          id: 'rn-manual-test-app',
+          version: '0.0.1',
+        },
       };
       let user = { key: userKey };
       try {
@@ -70,32 +63,34 @@ const Body = () => {
     }
 
     Alert.alert('LD Server Response', JSON.stringify(res));
-  }
+  };
 
   const track = () => {
     client.track(flagKey, false);
-  }
+  };
 
   const identify = () => {
     client.identify({ key: userKey });
-  }
+  };
 
   const listen = () => {
     if (listeners.hasOwnProperty(listenerKey)) {
       return;
     }
-    let listener = value => Alert.alert('Listener Callback', value);
+    let listener = (value) => Alert.alert('Listener Callback', value);
     client.registerFeatureFlagListener(listenerKey, listener);
-    setListeners({ ...listeners, ...{[listenerKey]: listener}});
-  }
+    setListeners({ ...listeners, ...{ [listenerKey]: listener } });
+  };
 
   const removeListener = () => {
     client.unregisterFeatureFlagListener(listenerKey, listeners[listenerKey]);
-    let {[listenerKey]: omit, ...newListeners} = listeners;
+    let { [listenerKey]: omit, ...newListeners } = listeners;
     setListeners(newListeners);
-  }
+  };
 
-  const flush = () => { client.flush(); }
+  const flush = () => {
+    client.flush();
+  };
 
   const setOffline = (newIsOffline) => {
     if (newIsOffline) {
@@ -104,18 +99,15 @@ const Body = () => {
       client.setOnline();
     }
     setIsOffline(newIsOffline);
-  }
+  };
 
   return (
     <>
       <Text>Feature Key:</Text>
-      <TextInput style={styles.input}
-                 onChangeText={setFlagKey} value={flagKey} />
+      <TextInput style={styles.input} onChangeText={setFlagKey} value={flagKey} autoCapitalize="none" />
       <View style={styles.row}>
         <Button title="Evaluate Flag" onPress={evalFlag} />
-        <Picker style={{flex: 1}}
-                selectedValue={flagType}
-                onValueChange={(itemValue, _) => setFlagType(itemValue)}>
+        <Picker style={{ flex: 1 }} selectedValue={flagType} onValueChange={(itemValue, _) => setFlagType(itemValue)}>
           <Picker.Item label="Bool" value="bool" />
           <Picker.Item label="String" value="string" />
           <Picker.Item label="Number" value="number" />
@@ -125,24 +117,21 @@ const Body = () => {
         <Switch value={isOffline} onValueChange={setOffline} />
       </View>
       <Text>User Key:</Text>
-      <TextInput style={styles.input}
-                 onChangeText={setUserKey} value={userKey} />
+      <TextInput style={styles.input} onChangeText={setUserKey} value={userKey} />
       <View style={styles.row}>
         <Button title="Identify" onPress={identify} />
         <Button title="Track" onPress={track} />
         <Button title="Flush" onPress={flush} />
       </View>
       <Text>Feature Flag Listener Key:</Text>
-      <TextInput style={styles.input}
-                 onChangeText={setListenerKey}
-                 value={listenerKey} />
+      <TextInput style={styles.input} onChangeText={setListenerKey} value={listenerKey} />
       <View style={styles.row}>
-        <Button title="Listen" onPress={listen}/>
-        <Button title="Remove" onPress={removeListener}/>
+        <Button title="Listen" onPress={listen} />
+        <Button title="Remove" onPress={removeListener} />
       </View>
     </>
   );
-}
+};
 
 const styles = StyleSheet.create({
   row: {
@@ -163,7 +152,7 @@ const App = () => {
       <Body />
     </Wrapper>
   );
-}
+};
 
 MessageQueue.spy((msg) => {
   if (msg.module != 'LaunchdarklyReactNativeClient' && !msg.method.includes('LaunchdarklyReactNativeClient')) {
@@ -176,14 +165,18 @@ MessageQueue.spy((msg) => {
   if (params.length >= 2) {
     let cbIdSucc = params[params.length - 1];
     let cbIdFail = params[params.length - 2];
-    if (Number.isInteger(cbIdSucc) && Number.isInteger(cbIdFail) &&
-        (cbIdSucc & 1) === 1 && (cbIdFail & 1) === 0 &&
-        (cbIdSucc >>> 1 === cbIdFail >>> 1)) {
+    if (
+      Number.isInteger(cbIdSucc) &&
+      Number.isInteger(cbIdFail) &&
+      (cbIdSucc & 1) === 1 &&
+      (cbIdFail & 1) === 0 &&
+      cbIdSucc >>> 1 === cbIdFail >>> 1
+    ) {
       params.splice(-2, 2, '<promise>');
     }
   }
 
-  logMsg += '(' + params.map(p => JSON.stringify(p)).join(', ') + ')';
+  logMsg += '(' + params.map((p) => JSON.stringify(p)).join(', ') + ')';
   console.log(logMsg);
 });
 

ManualTestApp/android/build.gradle

@@ -2,7 +2,6 @@
 
 buildscript {
     ext {
-        buildToolsVersion = "30.0.2"
         minSdkVersion = 21
         compileSdkVersion = 30
         targetSdkVersion = 30
@@ -13,7 +12,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath("com.android.tools.build:gradle:4.2.2")
+        classpath('com.android.tools.build:gradle:7.4.0')
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
     }

ManualTestApp/android/gradle.properties

@@ -26,3 +26,4 @@ android.enableJetifier=true
 
 # Version of flipper SDK to use with React Native
 FLIPPER_VERSION=0.99.0
+org.gradle.jvmargs=--add-opens java.base/java.io=ALL-UNNAMED

ManualTestApp/android/gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

ManualTestApp/app.json

@@ -1,4 +1,4 @@
 {
   "name": "ManualTestApp",
   "displayName": "ManualTestApp"
-}
+}

ManualTestApp/index.js

@@ -2,8 +2,8 @@
  * @format
  */
 
-import {AppRegistry} from 'react-native';
+import { AppRegistry } from 'react-native';
 import App from './App';
-import {name as appName} from './app.json';
+import { name as appName } from './app.json';
 
 AppRegistry.registerComponent(appName, () => App);

ManualTestApp/ios/ManualTestApp/Images.xcassets/AppIcon.appiconset/Contents.json

@@ -1,38 +1,38 @@
 {
-  "images" : [
+  "images": [
     {
-      "idiom" : "iphone",
-      "size" : "29x29",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "29x29",
+      "scale": "2x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "29x29",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "29x29",
+      "scale": "3x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "40x40",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "40x40",
+      "scale": "2x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "40x40",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "40x40",
+      "scale": "3x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "60x60",
-      "scale" : "2x"
+      "idiom": "iphone",
+      "size": "60x60",
+      "scale": "2x"
     },
     {
-      "idiom" : "iphone",
-      "size" : "60x60",
-      "scale" : "3x"
+      "idiom": "iphone",
+      "size": "60x60",
+      "scale": "3x"
     }
   ],
-  "info" : {
-    "version" : 1,
-    "author" : "xcode"
+  "info": {
+    "version": 1,
+    "author": "xcode"
   }
-}
+}

ManualTestApp/ios/ManualTestApp/Images.xcassets/Contents.json

@@ -1,6 +1,6 @@
 {
-  "info" : {
-    "version" : 1,
-    "author" : "xcode"
+  "info": {
+    "version": 1,
+    "author": "xcode"
   }
 }