Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

prepare 2.0.3 release #27

Merged
merged 14 commits into from
Nov 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
node_modules/
npm-debug.log
yarn-error.log
target/

# Xcode
#
Expand Down
2 changes: 1 addition & 1 deletion .ldrelease/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ template:
name: npm

sdk:
displayName: React Native
displayName: React Native
24 changes: 12 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,30 @@
Contributing to the LaunchDarkly Client-side SDK for React Native
================================================

LaunchDarkly has published an [SDK contributor's guide](https://docs.launchdarkly.com/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work. See below for additional information on how to contribute to this SDK.

Submitting bug reports and feature requests
------------------

The LaunchDarkly SDK team monitors the [issue tracker](https://github.com/launchdarkly/react-native-client-sdk/issues) in the SDK repository. Bug reports and feature requests specific to this SDK should be filed in this issue tracker. The SDK team will respond to all newly filed issues within two business days.

Submitting pull requests
------------------

We encourage pull requests and other contributions from the community. Before submitting pull requests, ensure that all temporary or unintended code is removed. Don't worry about adding reviewers to the pull request; the LaunchDarkly SDK team will add themselves. The SDK team will acknowledge all pull requests within two business days.

Build instructions
------------------

### Prerequisites

This SDK requires that you have [`npm`](https://www.npmjs.com/) and [`react-native-cli`](https://www.npmjs.com/package/react-native-cli) installed in order to develop with it.

### Building and running

You can modify and verify changes by developing within the LaunchDarkly React Native SDK sample application (`hello-react-native`).

1. In your `react-native-client-sdk` directory, run `npm link`.
2. Clone and setup the [`hello-react-native`](https://github.com/launchdarkly/hello-react-native) repository.
3. In your `hello-react-native` directory, copy your `react-native-client-sdk` into `node_modules` or use [wml](https://github.com/wix/wml) to monitor and copy files.
1. Clone and setup the [`hello-react-native`](https://github.com/launchdarkly/hello-react-native) repository.
2. In your `hello-react-native` directory, copy your `react-native-client-sdk` directory into `node_modules` as `launchdarkly-react-native-client-sdk`. Alternatively, you can use [wml](https://github.com/wix/wml) to monitor and copy files.
3. Launch your emulator (`emulator -avd <NAME>` for Android) or connect your device.
4. Test your changes in `hello-react-native` by running either `react-native run-ios` or `react-native run-android` depending on your desired runtime environment.
2 changes: 1 addition & 1 deletion android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<manifest package="com.reactlibrary">
<manifest package="com.launchdarkly.reactnative">

</manifest>
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.reactlibrary;
package com.launchdarkly.reactnative;

import android.app.Application;
import android.net.Uri;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

package com.reactlibrary;
package com.launchdarkly.reactnative;

import java.util.Arrays;
import java.util.Collections;
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"homepage": "https://docs.launchdarkly.com/docs/react-native-sdk-reference",
"peerDependencies": {
"react-native": "0.61.2",
"react-native": "~0.61.2",
"react": "16.9.0"
},
"devDependencies": {
Expand Down