This repository has been archived by the owner on Oct 29, 2024. It is now read-only.
feat: Add typings for LDClient #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contirbution, @eeynard! At first glance your changes looks good. We'll review them for completeness and correctness and will aim to get this into an upcoming release. |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Jan 25, 2020
* Changed start to startCompleteWhenFlagsReceived, serialize EvaluationDetail to NSDictionary, bump version numbers * Added evaluationReasons config option, removed unnecessary iOS serialization * Fixed Android config enum syntax error * Serialize iOS and Android EvaluationDetail * Parsing object to JSON to JSONObject to WriteableMap in Android native * Fixed jsonString type * Revert version number bump * Added static Gson object, simplified EvaluationDetail parsing on Android native * Remove invalid closing p tag from Android native JavaDoc
|
Thanks @eeynard for the contributions. This is a good start at introducing Typescript typedefs for the SDK. I'm accepting your PR to thank you for your effort, and will make additional changes for completeness and correctness before releasing this publicly in the next SDK version. |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Feb 20, 2020
* feat: Add typings for LDClient (#32) * typescript type definitions * typedoc * PR feedback * fix typos * setting default values to override platform inconsistencies
Merged
|
Type definitions are now available in 3.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
Here is a PR adding typescript typing to LDClient. It should be a good start but I am not an expert, so if someone wants to add some precisions feel free to contribute ! :)
Requirements
Related issues
#23
Describe the solution you've provided
LDClient class should be typed in typescript
Describe alternatives you've considered
--
Additional context
--