fix: Do not assume Rails.logger exists simply because it responds to the method #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails logger could be nil, leaving us with a nil value for logger, and unable to load the application due to the assumed presence of a logger.
codeodor
changed the title
codeodor
changed the title
keelerm84
approved these changes
Mar 21, 2024
|
Thank you for this contribution! |
|
My pleasure! |
keelerm84
pushed a commit
that referenced
this pull request
Mar 28, 2024
🤖 I have created a release *beep* *boop* --- ## [8.3.1](8.3.0...8.3.1) (2024-03-28) ### Bug Fixes * Ensure Rails.logger exists before using it ([#258](#258)) ([2f0f7ed](2f0f7ed)) * Remove invalid prereq `check_variation_range` check ([#261](#261)) ([#263](#263)) ([74ca206](74ca206)), closes [#260](#260) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
I did not validate it against all platform versions, but rather than use something like
present?ortryor&.I just used the ruby idiom for checking nil/false by using the object at the end, like&& objectHave you considered putting that last requirement into the CI's hands so that it might become unnecessary?
Related issues
None that I am aware of.
Describe the solution you've provided
The code previously checked that Rails responded to
loggerand if it did, assumes there is actually a logger present, which is not always the case. This leaves LD with anilvalue forloggerwhich causes the application to crash.Describe alternatives you've considered
I did not consider any alternatives.
Additional context
None.