Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to the LaunchDarkly Ruby SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).

## [2.0.3] - 2016-10-21
## Fixed
- Indirect stream events are now correctly processed

## [2.0.2] - 2016-08-08
## Changed
- The default logger now logs at `info` level
Expand Down
8 changes: 5 additions & 3 deletions lib/ldclient-rb/stream.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,24 +47,26 @@ def start
end

def process_message(message, method)
message = JSON.parse(message.data, symbolize_names: true)
@config.logger.debug("[LDClient] Stream received #{method} message")
if method == PUT
message = JSON.parse(message.data, symbolize_names: true)
@store.init(message)
@initialized.make_true
@config.logger.info("[LDClient] Stream initialized")
elsif method == PATCH
message = JSON.parse(message.data, symbolize_names: true)
@store.upsert(message[:path][1..-1], message[:data])
elsif method == DELETE
message = JSON.parse(message.data, symbolize_names: true)
@store.delete(message[:path][1..-1], message[:version])
elsif method == INDIRECT_PUT
@store.init(@requestor.request_all_flags)
@initialized.make_true
@config.logger.info("[LDClient] Stream initialized (via indirect message)")
elsif method == INDIRECT_PATCH
@store.upsert(@requestor.request_flag(message[:data]))
@store.upsert(message.data, @requestor.request_flag(message.data))
else
@config.logger.error("[LDClient] Unknown message received: #{method}")
@config.logger.warn("[LDClient] Unknown message received: #{method}")
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/ldclient-rb/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module LaunchDarkly
VERSION = "2.0.2"
VERSION = "2.0.3"
end
4 changes: 2 additions & 2 deletions spec/stream_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
processor.send(:process_message, delete_message, LaunchDarkly::DELETE)
expect(processor.instance_variable_get(:@store).get("key")).to eq(nil)
end
it "will log an error if the method is not recognized" do
expect(processor.instance_variable_get(:@config).logger).to receive :error
it "will log a warning if the method is not recognized" do
expect(processor.instance_variable_get(:@config).logger).to receive :warn
processor.send(:process_message, put_message, "get")
end
end
Expand Down