Bypass worker parsing in response streams #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etween DO & Client.
dan-lee
reviewed
Nov 25, 2022
Comment on lines
+35
to
+42
| // redirect stream from DO directly to client without parsing to keep stream connection client <-> DO | ||
| // @ts-ignore | ||
| context.___stream_response = await durableObject.fetch(request.url, { | ||
| method: 'POST', | ||
| body, | ||
| headers, | ||
| }); | ||
| return {} as any; |
There was a problem hiding this comment.
This looks intriguing, can you explain a little bit more about how this does replace the flow from before?
There was a problem hiding this comment.
@dan-lee The existing flow is unwrapping the eventstream in the worker, and re-encoding it to send to the client. This should not be needed, the worker just needs pass the DO response to the client. It's my understanding that the current implementation will keep both the DO instance & the worker reciving the initial response active for the length of the stream. While if the response is just proxied only the DO will be kept alive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable direct connection between DO & Client.
Remove response clone
Add prepare command to support loading dependency from git