Prbranch #45
Merged
Prbranch #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It less likely we will encounter system permission changes that affect the app's read/write access by using the system-determined temp path instead of always using Window's temp directory.
Signed-off-by: Alessandro Bellia <casilda.bell85@gmail.com>
lauralex
added a commit
that referenced
this pull request
Jan 13, 2024
* Reduce probability of temp file permission errors It less likely we will encounter system permission changes that affect the app's read/write access by using the system-determined temp path instead of always using Window's temp directory. * Add missing trailing path separator * Privilege escalation Signed-off-by: Alessandro Bellia <casilda.bell85@gmail.com> --------- Signed-off-by: Alessandro Bellia <casilda.bell85@gmail.com> Co-authored-by: CJ Davis <code@cjdavis.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #44
It less likely we will encounter system permission changes that affect the app's read/write access by using the system-determined temp path instead of always using Window's temp directory.
Add missing trailing path separator
Privilege escalation
Signed-off-by: Alessandro Bellia casilda.bell85@gmail.com
Signed-off-by: Alessandro Bellia casilda.bell85@gmail.com
Co-authored-by: CJ Davis code@cjdavis.me