Desktop: refactor: Refactored props and added types to it

laurent22 · Apr 2, 2024 · 9832a9e · 9832a9e
1 parent bef11bb
commit 9832a9e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/packages/app-desktop/gui/ConfigScreen/ConfigScreen.tsx b/packages/app-desktop/gui/ConfigScreen/ConfigScreen.tsx
@@ -590,7 +590,7 @@ class ConfigScreenComponent extends React.Component<any, any> {
 									updateSettingValue={updateSettingValue}
 									inputType={inputType}
 									inputStyle={inputStyle}
-									settings={this.state.settings}
+									fieldValue={this.state.settings[key]}
 									fonts={this.state.fonts}
 								/> :
 								<input

diff --git a/packages/app-desktop/gui/ConfigScreen/FontSearch.tsx b/packages/app-desktop/gui/ConfigScreen/FontSearch.tsx
@@ -20,8 +20,17 @@ const optionStyle: CSSProperties = {
 	cursor: 'pointer',
 };
 
-const FontSearch = (props: any) => {
-	const { _key: key, updateSettingValue, inputType, inputStyle, settings, fonts } = props;
+interface Props {
+	_key: string;
+	updateSettingValue: (key: string, value: string)=> void;
+	inputType: string;
+	inputStyle: CSSProperties;
+	fieldValue: string;
+	fonts: string[];
+}
+
+const FontSearch = (props: Props) => {
+	const { _key: key, updateSettingValue, inputType, inputStyle, fieldValue, fonts } = props;
 	const [hoveredFont, setHoveredFont] = useState('');
 	const [inputText, setInputText] = useState('');
 	const areFontsLoading = fonts.length === 0;
@@ -55,7 +64,7 @@ const FontSearch = (props: any) => {
 			<input
 				type={inputType}
 				style={inputStyle}
-				value={settings[key]}
+				value={fieldValue}
 				id={key}
 				onChange={(event: any) => {
 					onTextChange(event);