Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop preview caret invisible in dark mode #11336

Closed
annoyedhumanoid opened this issue Nov 7, 2024 · 3 comments · Fixed by #11345
Closed

Drag and drop preview caret invisible in dark mode #11336

annoyedhumanoid opened this issue Nov 7, 2024 · 3 comments · Fixed by #11345
Labels
bug It's a bug editor medium Medium priority issues

Comments

@annoyedhumanoid
Copy link

Operating system

macOS

Joplin version

3.1.23

Desktop version info

Joplin 3.1.23 (prod, darwin)

Client ID: 11cb0a2d420047cd9119a44d443e827c
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: b3ea127

Backup: 1.4.2
Note Statistics: 1.0.4

Current behaviour

Version 3.1.22 fixed issue #11274 "Dragging and dropping text no longer shows preview caret", so that there is a drag-and-drop preview caret now, but it's black even in dark mode, which makes it nearly invisible:

Screen.Recording.2024-11-05.at.10.22.45.mov

It can be seen in the highlighted text, but nowhere outside of it.

Expected behaviour

No response

Logs

No response

@annoyedhumanoid annoyedhumanoid added the bug It's a bug label Nov 7, 2024
@personalizedrefrigerator personalizedrefrigerator added editor medium Medium priority issues labels Nov 7, 2024
@personalizedrefrigerator
Copy link
Collaborator

Thank you for reporting this!

Development information: theme.ts will likely need to be updated to style the drop cursor in addition to the standard cursor.

@RgiriH
Copy link

RgiriH commented Nov 7, 2024

Is the colour of the text need to be white in dark mode?

Repository owner deleted a comment from VANSH3104 Nov 8, 2024
@LEVIII007
Copy link

@annoyedhumanoid @personalizedrefrigerator I have made a pull request regarding this issue. I have added the drop cursor color config to the dark theme in theme.ts file. Please review it. Thank you

laurent22 added a commit that referenced this issue Nov 10, 2024
Co-authored-by: Laurent Cozic <laurent22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug editor medium Medium priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants